flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fabian Hueske (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1020) Add minBy() and maxBy() selection functions
Date Tue, 12 Aug 2014 09:16:11 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093914#comment-14093914

Fabian Hueske commented on FLINK-1020:

Since the functionality is implemented using regular Reduce functions without any modifications
of the compile time code, I would go for simple unit tests and skip runtime-intensive integration

Have a look at {{GroupingTest.java}} for the pre-runtime checks (index bounds, comparable,
etc.). The correctness of the {{MinReduceFunction}} and {{MaxReduceFunction}} should be checked
by calling the {{reduce()}} methods with different sets of tuples. 

I would also rename the functions to something like {{SelectByMinFunction}} and {{SelectByMaxFunction}}.

> Add minBy() and maxBy() selection functions
> -------------------------------------------
>                 Key: FLINK-1020
>                 URL: https://issues.apache.org/jira/browse/FLINK-1020
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API
>    Affects Versions: 0.6-incubating
>            Reporter: Stephan Ewen
>            Assignee: Tobias
>            Priority: Minor
>              Labels: starter
>             Fix For: 0.6-incubating
> Adding a minBy() and maxBy() function is a valuable addition. Those are not aggregation
functions, because they do not work on individual fields.
> They can be implemented as a simple reduce.

This message was sent by Atlassian JIRA

View raw message