flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: [FLINK-909], [FLINK945] Remove addit...
Date Fri, 08 Aug 2014 12:35:59 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/91#discussion_r15990179
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/AbstractIterativePactTask.java
---
    @@ -210,28 +210,17 @@ public RuntimeAggregatorRegistry getIterationAggregators() {
     		return this.iterationAggregators;
     	}
     
    -	protected void checkForTerminationAndResetEndOfSuperstepState() throws IOException {
    +	protected void verifyEndOfSuperstepState() throws IOException {
    --- End diff --
    
    The is still a sanity check, but the distinction between end-of-superstep and termination
comes no longer from the readers, but from the specific shared sync.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message