Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 36AD411275 for ; Tue, 8 Jul 2014 15:05:29 +0000 (UTC) Received: (qmail 59783 invoked by uid 500); 8 Jul 2014 15:05:29 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 59755 invoked by uid 500); 8 Jul 2014 15:05:29 -0000 Mailing-List: contact issues-help@flink.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.incubator.apache.org Delivered-To: mailing list issues@flink.incubator.apache.org Received: (qmail 59745 invoked by uid 99); 8 Jul 2014 15:05:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jul 2014 15:05:29 +0000 X-ASF-Spam-Status: No, hits=-2000.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 08 Jul 2014 15:05:30 +0000 Received: (qmail 55298 invoked by uid 99); 8 Jul 2014 15:05:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jul 2014 15:05:04 +0000 Date: Tue, 8 Jul 2014 15:05:04 +0000 (UTC) From: "Henry Saputra (JIRA)" To: issues@flink.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-1007) Clean up and refactor on Scala and Java code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/FLINK-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055013#comment-14055013 ] Henry Saputra commented on FLINK-1007: -------------------------------------- Thanks [~aljoscha] for merging the PR. Let's just close this ticket. I will make new JIRAs for follow up to simplify our life =) > Clean up and refactor on Scala and Java code > -------------------------------------------- > > Key: FLINK-1007 > URL: https://issues.apache.org/jira/browse/FLINK-1007 > Project: Flink > Issue Type: Improvement > Components: Scala API > Reporter: Henry Saputra > Assignee: Henry Saputra > Priority: Minor > Fix For: 0.6-incubating > > > First cleanup attempt, mostly on Scala code, to follow guidelines from http://docs.scala-lang.org/style: > 1. Remove return statement from Scala code where it is not necessary (end of method definition) > 2. Remove extra semicolon (;) from Scala and Java code > 3. First drop to abide to 100 chars per line for Scala code. > Will send another PR for other files as I have encountered. > 4. Remove parentheses for empty argument methods that do not have side effect > (see http://www.artima.com/pins1ed/composition-and-inheritance.html#i1343251059-1) > 5. Remove unused import statements in Scala code as I have encountered them. > This is first drop to refactor and cleanup Scala code to see comment/ response from community. > More PRs for follow up code will come. -- This message was sent by Atlassian JIRA (v6.2#6252)