Mailing-List: contact issues-help@flink.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.incubator.apache.org
Date: Tue, 29 Jul 2014 16:05:39 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.incubator.apache.org
Message-ID: <JIRA.12724958.1404304007984.65995.1406649939581@arcas>
In-Reply-To: <JIRA.12724958.1404304007984@arcas>
References: <JIRA.12724958.1404304007984@arcas>
Subject: [jira] [Commented] (FLINK-998) NettyConnectionManager does not
 close connections
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FLINK-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077889#comment-14077889 ] 

ASF GitHub Bot commented on FLINK-998:
--------------------------------------

Github user uce commented on the pull request:

    https://github.com/apache/incubator-flink/pull/76#issuecomment-50497817
  
    I got around to testing this on a 25 node cluster and fixed a small remaining problem. Looks good to me now.
    
    Although it uses more coarse-grained locking than the current master, the performance did not suffer in comparison. We should improve it when it becomes a problem.
    
    The connections are reliably closed after the idle timeout and the debug logs indicate that they have also been closed/opened during execution jobs without problems.


> NettyConnectionManager does not close connections
> -------------------------------------------------
>
>                 Key: FLINK-998
>                 URL: https://issues.apache.org/jira/browse/FLINK-998
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Runtime
>    Affects Versions: pre-apache-0.5.1
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>            Priority: Critical
>
> Network connections created via NettyConnectionManager are not closed.


--
This message was sent by Atlassian JIRA
(v6.2#6252)