Mailing-List: contact issues-help@flink.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.incubator.apache.org
Date: Tue, 8 Jul 2014 07:43:34 +0000 (UTC)
From: "Robert Metzger (JIRA)" <jira@apache.org>
To: issues@flink.incubator.apache.org
Message-ID: <JIRA.12719833.1402317763532.18115.1404805414434@arcas>
In-Reply-To: <JIRA.12719833.1402317763532@arcas>
References: <JIRA.12719833.1402317763532@arcas>
Subject: [jira] [Commented] (FLINK-655) Rename
 DataSet.withBroadcastSet(DataSet, String) method
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FLINK-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054614#comment-14054614 ] 

Robert Metzger commented on FLINK-655:
--------------------------------------

I'm not sure if we still want this renaming. The discussion happened before the 0.5 release. If we change this, our users have to change their code with the 0.6 release.
The package renaming from Stratosphere to Flink is not a good argument here, because thats just a replacement of the imports.

> Rename DataSet.withBroadcastSet(DataSet, String) method
> -------------------------------------------------------
>
>                 Key: FLINK-655
>                 URL: https://issues.apache.org/jira/browse/FLINK-655
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ufuk Celebi
>              Labels: github-import, starter
>             Fix For: pre-apache
>
>
> To broadcast a data set you have to do the following:
> ```java
> lorem.map(new MyMapper()).withBroadcastSet(toBroadcast, "toBroadcastName")
> ```
> In the operator you call:
> ```java
> getRuntimeContext().getBroadcastVariable("toBroadcastName")
> ```
> I propose to have both method names consistent, e.g.
>   - `withBroadcastVariable(DataSet, String)`, or
>   - `getBroadcastSet(String)`.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/655
> Created by: [uce|https://github.com/uce]
> Labels: enhancement, java api, user satisfaction, 
> Created at: Wed Apr 02 16:29:08 CEST 2014
> State: open


--
This message was sent by Atlassian JIRA
(v6.2#6252)