Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 65A9711F88 for ; Thu, 3 Jul 2014 11:47:20 +0000 (UTC) Received: (qmail 31389 invoked by uid 500); 3 Jul 2014 11:47:20 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 31251 invoked by uid 500); 3 Jul 2014 11:47:20 -0000 Mailing-List: contact issues-help@flink.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.incubator.apache.org Delivered-To: mailing list issues@flink.incubator.apache.org Received: (qmail 31113 invoked by uid 99); 3 Jul 2014 11:47:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jul 2014 11:47:20 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 03 Jul 2014 11:47:19 +0000 Received: (qmail 30514 invoked by uid 99); 3 Jul 2014 11:46:58 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jul 2014 11:46:58 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 4F60B9958C4; Thu, 3 Jul 2014 11:46:58 +0000 (UTC) From: StephanEwen To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-flink pull request: New operator map partition function Content-Type: text/plain Message-Id: <20140703114658.4F60B9958C4@tyr.zones.apache.org> Date: Thu, 3 Jul 2014 11:46:58 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/incubator-flink/pull/42#discussion_r14509280 --- Diff: stratosphere-java/src/main/java/eu/stratosphere/api/java/DataSet.java --- @@ -135,6 +139,27 @@ public ExecutionEnvironment getExecutionEnvironment() { } return new MapOperator(this, mapper); } + + + + /** + * Applies a Map transformation on a {@link DataSet} by using an iterator.
--- End diff -- I think this comment is not quite correct. Something more appropriate is ``` Applies a Map operation to the entire partition of the data. The function is called once per parallel partition of the data, and the entire partition is available through the given Iterator. The number of elements that each instance of the MapPartition function sees is non deterministic and depends on the degree of parallelism of the operation. This function is intended for operations that cannot transform individual elements, requires no grouping of elements. To transform individual elements, the use of {@code map()} and {@code flatMap()} is preferable." --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---