flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Saputra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1007) Clean up and refactor on Scala and Java code
Date Tue, 08 Jul 2014 15:05:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055013#comment-14055013

Henry Saputra commented on FLINK-1007:

Thanks [~aljoscha] for merging the PR. Let's just close this ticket. I will make new JIRAs
for follow up to simplify our life =)

> Clean up and refactor on Scala and Java code
> --------------------------------------------
>                 Key: FLINK-1007
>                 URL: https://issues.apache.org/jira/browse/FLINK-1007
>             Project: Flink
>          Issue Type: Improvement
>          Components: Scala API
>            Reporter: Henry Saputra
>            Assignee: Henry Saputra
>            Priority: Minor
>             Fix For: 0.6-incubating
> First cleanup attempt, mostly on Scala code, to follow guidelines from http://docs.scala-lang.org/style:
> 1. Remove return statement from Scala code where it is not necessary (end of method definition)
> 2. Remove extra semicolon (;) from Scala and Java code
> 3. First drop to abide to 100 chars per line for Scala code.
>    Will send another PR for other files as I have encountered.
> 4. Remove parentheses for empty argument methods that do not have side effect
>    (see http://www.artima.com/pins1ed/composition-and-inheritance.html#i1343251059-1)
> 5. Remove unused import statements in Scala code as I have encountered them.
> This is first drop to refactor and cleanup Scala code to see comment/ response from community.
> More PRs for follow up code will come.

This message was sent by Atlassian JIRA

View raw message