flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Common API based on SAM interfaces r...
Date Tue, 29 Jul 2014 17:43:47 GMT
Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/85#issuecomment-50511543
  
    I see two options regarding the Java8 tests: 
    a) We create a "flink-java8-tests" maven module that is only included into the build if
java8 is present (we can do this via build profiles that activate at certain java versions).
    
    b) We integrate the java8 tests into the regular "flink-tests" module, into a separate
package and do some maven includes / excludes tricks with build profiles.
    
    I vote for option a) it is cleaner and easier to do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message