flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: hadoopcompatibility: Implementations...
Date Tue, 29 Jul 2014 10:31:46 GMT
Github user fhueske commented on the pull request:

    Hi @atsikiridis,
    please add new commits to this PR and do not squash and force push the branch. Otherwise,
all previous code comments are gone and not longer available.
    The `FlinkHadoopJobClient.submitJob()` method looks much better and I checked that Configuration
values are correctly passed.
    There are a few issues that I commented inline.
    Also please add JavaDocs to all public methods of user-facing classes and check if you
can get rid of some of the `rawType` warnings (use `@SuppressWarnings("rawtype")` if not possible).

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message