flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mariemayadi <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Add Pi approximation Java example
Date Fri, 25 Jul 2014 09:18:37 GMT
Github user mariemayadi commented on the pull request:

    https://github.com/apache/incubator-flink/pull/78#issuecomment-50126545
  
    I really like the filter suggestion. It is indeed a more suitable fit for the records
emission.
    +1 for ReduceFunction Vs GroupReduceFunction. Fair point. (I was trying to avoid having
to use an additional MapFunction :)
    
    Will fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message