flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Add Pi approximation Java example
Date Thu, 24 Jul 2014 20:29:03 GMT
Github user fhueske commented on the pull request:

    Nice one!
    I'd prefer to use a ReduceFunction instead of a GroupReduceFunction because it is automatically
combinable (which is usually important if you do a Reduce without groupBy) and shorter.
    However, you would need to add another MapFunction for the final division.
    You could also replace the first MapFunction by a FilterFunction and emit only a record
if the test is passed. This would mean that no records with 0-valued ints are emitted and
therefore the summing becomes cheaper.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message