flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: [FLINK-987] Add seeking to DataOutpu...
Date Tue, 22 Jul 2014 13:35:31 GMT
Github user uce commented on a diff in the pull request:

    --- Diff: flink-core/src/main/java/org/apache/flink/core/memory/DataOutputView.java ---
    @@ -51,4 +55,38 @@
     	 *                     could not be read, or the output could not be written.
     	public void write(DataInputView source, int numBytes) throws IOException;
    +	/**
    +	 * Tells the view to keep the underlying buffers (if any) and allow calling of {@link
#seek(long)} and {@link
    +	 * #tell()}.
    +	 */
    +	public void lock();
    +	/**
    +	 * Tells the system to spill all underlying buffers (if any). Data written after the
current writing position might
    --- End diff --
    I think `spill` might be confusing in this context? In my head `memory + spill = go to
disk`. :laughing: 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message