flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: [FLINK-1003] Added spread out schedu...
Date Mon, 07 Jul 2014 15:12:49 GMT
Github user uce commented on the pull request:

    https://github.com/apache/incubator-flink/pull/60#issuecomment-48191640
  
    Great! :-) Looks good to me minus the following two comments:
    
    1. I don't have a better idea right now, but the SchedulingStrategy name `FillFirst` might
be confusing as all instances are filled and not just the the first -- which someone might
think by reading the name.
    
    2. I think we should add some test cases before we merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message