flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timo Walther (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FLINK-8379) Improve type checking for DataView
Date Fri, 05 Jan 2018 16:05:00 GMT
Timo Walther created FLINK-8379:
-----------------------------------

             Summary: Improve type checking for DataView
                 Key: FLINK-8379
                 URL: https://issues.apache.org/jira/browse/FLINK-8379
             Project: Flink
          Issue Type: Improvement
          Components: Table API & SQL
            Reporter: Timo Walther


At the moment an accumulator with no proper type information is a valid accumulator.
{code}
	public static class CountDistinctAccum {
		public MapView<Tuple, Integer> map;
		public long count;
	}
{code}

I quickly looked into the code and it seems that MapView with type information for key and
value can be null. We should add a null check at the correct position to inform the user about
the non-existing type information. We should also add the type check added with FLINK-8139
for the key type of MapView.





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message