flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tzu-Li (Gordon) Tai (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FLINK-8306) FlinkKafkaConsumerBaseTest has invalid mocks on final methods
Date Thu, 21 Dec 2017 18:53:01 GMT
Tzu-Li (Gordon) Tai created FLINK-8306:
------------------------------------------

             Summary: FlinkKafkaConsumerBaseTest has invalid mocks on final methods
                 Key: FLINK-8306
                 URL: https://issues.apache.org/jira/browse/FLINK-8306
             Project: Flink
          Issue Type: Bug
          Components: Kafka Connector, Tests
            Reporter: Tzu-Li (Gordon) Tai
            Assignee: Tzu-Li (Gordon) Tai
             Fix For: 1.5.0, 1.4.1


The {{FlinkKafkaConsumerBaseTest}} has invalid mocks on a final {{AbstractFetcher::commitInternalOffsetsToKafka(...)}}
method. While an easy fix would be to simply make that method non-final, that is not ideal
since it would be best that the method is left final to prevent overrides in subclasses.

This suggests that offset committing functionality is too tightly coupled with the {{AbstractFetcher}},
making it hard to perform concise tests to verify offset committing.

I suggest that we decouple record fetching and offset committing as separate services behind
different interfaces. We should introduce a new interface, say {{KafkaOffsetCommitter}}, and
test against that instead. Initially, we can simply let {{AbstractFetcher}} implement {{KafkaOffsetCommitter}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message