Mailing-List: contact dev-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: Greg Hogan <code@greghogan.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [VOTE] Release Apache Flink-shaded 1.0 (RC1)
Date: Sun, 23 Jul 2017 19:58:59 -0400
References: <1f22021c-ab98-90b5-f10e-47abeea675c8@apache.org>
 <5dcd645f-e43d-9c5f-75ed-b0f53308da42@apache.org>
 <CAGr9p8APr3HcTpT3HLjOJeiaVa1-WMnQhT+VPeCLipR7ntS4Ew@mail.gmail.com>
 <CANC1h_sCPSEccY5Cmo+Rkz-3SbiuTysPzAb0Fx018fPS+b2Zpg@mail.gmail.com>
To: dev@flink.apache.org
In-Reply-To: <CANC1h_sCPSEccY5Cmo+Rkz-3SbiuTysPzAb0Fx018fPS+b2Zpg@mail.gmail.com>
Message-Id: <D8163F90-1BF9-451E-B490-34EB9CFD12EF@greghogan.com>
archived-at: Sun, 23 Jul 2017 23:59:04 -0000

Is there a pressing need to get the release out quickly? This being the =
first release, would it be better to change the versioning now to =
prevent future confusion? Even if Flink is the only intended consumer =
we=E2=80=99ll still be publishing the jars.


> On Jul 23, 2017, at 9:41 AM, Stephan Ewen <sewen@apache.org> wrote:
>=20
> The release is technically correct, so
> +1 for the release
>=20
>  - LICENSE and NOTICE are good
>  - Shaded artifacts add their licenses to the artifact where needed
>  - no binaries in the release
>=20
>=20
> I will send another mail with suggestions for improving things for =
future
> releases
>=20
>=20
> On Fri, Jul 21, 2017 at 11:39 AM, Robert Metzger <rmetzger@apache.org>
> wrote:
>=20
>> Thanks a lot for preparing the release artifacts.
>> While checking the source repo / release commit, I realized that you =
are
>> not following the versioning scheme as flink:
>> the current master has a "x.y-SNAPSHOT" version, and release =
candidates
>> (and releases) get a x.y.z version. I wonder if it makes sense to use =
the
>> same model in the flink-shaded.git repo. I think this is the default
>> assumption in maven, and some modules behave differently based on the
>> version: for example "mvn deploy" sends "-SNAPSHOT" artifacts to a =
snapshot
>> server, and release artifacts to a staging repository.
>>=20
>> I don't think we need to cancel the release because of this, I just =
wanted
>> to raise this point to see what others are thinking.
>>=20
>>=20
>> I've checked the following
>> - The netty shaded jar contains the MIT license from netty router:
>> https://repository.apache.org/content/repositories/
>> orgapacheflink-1130/org/apache/flink/flink-shaded-
>> netty-4/1.0-4.0.27.Final/flink-shaded-netty-4-1.0-4.0.27.Final.jar
>> - In the staging repo, I didn't see any dependencies exposed.
>> - I checked some of the md5 sums in the staging and they were correct =
/ I
>> used a mvn plugin to check the signatures in the staging repo and =
they were
>> okay
>> - clean install in the source repo worked (this includes a license =
header
>> check)
>> - LICENSE and NOTICE file are there
>>=20
>> =3D=3D> +1 to release.
>>=20
>> On Fri, Jul 21, 2017 at 9:45 AM, Chesnay Schepler =
<chesnay@apache.org>
>> wrote:
>>=20
>>> Here's a list of things we need to check:
>>>=20
>>> * correct License/Notice files
>>> * licenses of shaded dependencies are included in the jar
>>> * the versions of shaded dependencies match those used in Flink 1.4
>>> * compilation with maven works
>>> * the assembled jars only contain the shaded dependency and no
>>>   non-shaded classes
>>> * no transitive dependencies should be exposed
>>>=20
>>>=20
>>> On 19.07.2017 15:59, Chesnay Schepler wrote:
>>>=20
>>>> Dear Flink community,
>>>>=20
>>>> Please vote on releasing the following candidate as Apache =
Flink-shaded
>>>> version 1.0.
>>>>=20
>>>> The commit to be voted in:
>>>> https://gitbox.apache.org/repos/asf/flink-shaded/commit/fd30
>>>> 33ba9ead310478963bf43e09cd50d1e36d71
>>>>=20
>>>> Branch:
>>>> release-1.0-rc1
>>>>=20
>>>> The release artifacts to be voted on can be found at:
>>>> http://home.apache.org/~chesnay/flink-shaded-1.0-rc1/ <
>>>> http://home.apache.org/%7Echesnay/flink-shaded-1.0-rc1/>
>>>>=20
>>>> The release artifacts are signed with the key with fingerprint
>>>> 19F2195E1B4816D765A2C324C2EED7B111D464BA:
>>>> http://www.apache.org/dist/flink/KEYS
>>>>=20
>>>> The staging repository for this release can be found at:
>>>> =
https://repository.apache.org/content/repositories/orgapacheflink-1130
>>>>=20
>>>> -------------------------------------------------------------
>>>>=20
>>>>=20
>>>> The vote ends on Monday (5pm CEST), July 24th, 2017.
>>>>=20
>>>> [ ] +1 Release this package as Apache Flink-shaded 1.0
>>>> [ ] -1 Do not release this package, because ...
>>>>=20
>>>> -------------------------------------------------------------
>>>>=20
>>>>=20
>>>> The flink-shaded project contains a number of shaded dependencies =
for
>>>> Apache Flink.
>>>>=20
>>>> This release includes asm-all:5.0.4, guava:18.0, =
netty-all:4.0.27-FINAL
>>>> and netty-router:1.10 . Note that netty-all and netty-router are
>> bundled as
>>>> a single dependency.
>>>>=20
>>>> The purpose of these dependencies is to provide a single instance =
of a
>>>> shaded dependency in the Apache Flink distribution, instead of each
>>>> individual module shading the dependency.
>>>>=20
>>>> For more information, see
>>>> https://issues.apache.org/jira/browse/FLINK-6529.