flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chesnay Schepler (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FLINK-7069) Catch exceptions for each reporter separately
Date Mon, 03 Jul 2017 13:47:00 GMT
Chesnay Schepler created FLINK-7069:
---------------------------------------

             Summary: Catch exceptions for each reporter separately
                 Key: FLINK-7069
                 URL: https://issues.apache.org/jira/browse/FLINK-7069
             Project: Flink
          Issue Type: Improvement
          Components: Metrics
    Affects Versions: 1.3.1, 1.4.0
            Reporter: Chesnay Schepler
            Assignee: Chesnay Schepler
             Fix For: 1.4.0


The metric system can be effectively disabled by a reporter that throws exceptions whenever
it is notified of adding metrics.

The reason is that the catching of exceptions isn't granular enough, as this peace of psude
code shows:

{code}
addMetric(metric):
	try
		for reporter in reporters:
			reporter.addMetric(metric)
		metricQueryService.addMetric(metric)
	catch (e)
		logError(e)	
{code}

If a reporter throws an exception we never even attempt the other reporters, not notify the
MQS which disabled metrics in the WebUI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message