flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Ewen <se...@apache.org>
Subject Re: [DISCUSS] NOTICE
Date Wed, 12 Jul 2017 14:34:19 GMT
Hi!

I general, adopting code from other Apache projects is okay and needs no
special notice (per the Apache License 2.0). It is good style to add
comments above the copied code, definitely.

As far as I understand it, you add an entry to the NOTICE file when you
find other NOTICE files, or when the license of the copied code requires
that.
In the lodash JavaScript file is a comment that I interpreted that this
needs to be carried into the NOTICE file.

Does that answer the question?

Stephan


On Wed, May 31, 2017 at 3:13 PM, Greg Hogan <code@greghogan.com> wrote:

> In several locations we have copied code from external projects, for
> example
> flink-scala-shell/src/main/java/org/apache/flink/api/java/JarHelper.java
> links to the file from org.apache.xmlbeans/xmlbeans/2.4.0. We also have
> copied from Apache's Calcite, Spark, and Hadoop.
>
> None of these projects are referenced in Flink's NOTICE or LICENSE. Is this
> unnecessary because all Apache project code is is copyright the ASF (or
> public domain)?
>
> Also, lodash is cited in Flink's NOTICE but there is no lodash NOTICE at
> https://github.com/lodash/lodash. We do properly cite the project in the
> MIT License section of Flink's LICENSE.
>
> Greg
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message