Return-Path: <dev-return-18635-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id DCB2F200CB3
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 26 Jun 2017 17:05:16 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id DB877160BDE; Mon, 26 Jun 2017 15:05:16 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 2DF02160BD9
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 26 Jun 2017 17:05:16 +0200 (CEST)
Received: (qmail 97480 invoked by uid 500); 26 Jun 2017 15:05:15 -0000
Mailing-List: contact dev-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@flink.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@flink.apache.org>
List-Post: <mailto:dev@flink.apache.org>
List-Id: <dev.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list dev@flink.apache.org
Received: (qmail 97468 invoked by uid 99); 26 Jun 2017 15:05:14 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jun 2017 15:05:14 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id DA0AEDFE8B; Mon, 26 Jun 2017 15:05:14 +0000 (UTC)
From: zentol <git@git.apache.org>
To: dev@flink.apache.org
Reply-To: dev@flink.apache.org
References: <git-pr-1-flink-shaded@git.apache.org>
In-Reply-To: <git-pr-1-flink-shaded@git.apache.org>
Subject: [GitHub] flink-shaded pull request #1: [FLINK-6981] Add flink-shaded-guava module
Content-Type: text/plain
Message-Id: <20170626150514.DA0AEDFE8B@git1-us-west.apache.org>
Date: Mon, 26 Jun 2017 15:05:14 +0000 (UTC)
archived-at: Mon, 26 Jun 2017 15:05:17 -0000

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink-shaded/pull/1#discussion_r124034556
  
    --- Diff: flink-shaded-guava-18/pom.xml ---
    @@ -0,0 +1,99 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    +
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <parent>
    +        <groupId>org.apache.flink</groupId>
    +        <artifactId>flink-shaded</artifactId>
    +        <version>1.0</version>
    +        <relativePath>..</relativePath>
    +    </parent>
    +
    +    <artifactId>flink-shaded-guava-18</artifactId>
    +    <name>flink-shaded-guava-18</name>
    +    <version>1.0-${guava.version}</version>
    +
    +    <packaging>jar</packaging>
    +
    +    <properties>
    +        <guava.version>18.0</guava.version>
    +    </properties>
    +
    +    <dependencies>
    +        <dependency>
    +            <groupId>com.google.guava</groupId>
    +            <artifactId>guava</artifactId>
    +            <version>${guava.version}</version>
    +            <optional>true</optional>
    +        </dependency>
    +    </dependencies>
    +
    +    <build>
    +        <plugins>
    +            <plugin>
    +                <groupId>org.apache.maven.plugins</groupId>
    +                <artifactId>maven-shade-plugin</artifactId>
    +                <executions>
    +                    <execution>
    +                        <id>shade-flink</id>
    +                        <phase>package</phase>
    +                        <goals>
    +                            <goal>shade</goal>
    +                        </goals>
    +                        <configuration>
    +                            <createDependencyReducedPom>false</createDependencyReducedPom>
    --- End diff --
    
    Since guava is marked as optional the dependency isn't exposed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---