flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink-shaded pull request #1: [FLINK-6981] Add flink-shaded-guava module
Date Mon, 26 Jun 2017 15:16:59 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink-shaded/pull/1#discussion_r124037728
  
    --- Diff: flink-shaded-guava-18/pom.xml ---
    @@ -0,0 +1,99 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    +
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <parent>
    +        <groupId>org.apache.flink</groupId>
    +        <artifactId>flink-shaded</artifactId>
    +        <version>1.0</version>
    +        <relativePath>..</relativePath>
    +    </parent>
    +
    +    <artifactId>flink-shaded-guava-18</artifactId>
    +    <name>flink-shaded-guava-18</name>
    +    <version>1.0-${guava.version}</version>
    +
    +    <packaging>jar</packaging>
    +
    +    <properties>
    +        <guava.version>18.0</guava.version>
    +    </properties>
    +
    +    <dependencies>
    +        <dependency>
    +            <groupId>com.google.guava</groupId>
    +            <artifactId>guava</artifactId>
    +            <version>${guava.version}</version>
    +            <optional>true</optional>
    --- End diff --
    
    I remembered why i did it this way. When relying on the shade-plugin the dependency is
only hidden when working against the dependency-reduced pom, i.e when pulling the dependency
from maven.
    
    But in an earlier version this module was part of Flink. This caused the IDE to pick up
guava as a transitive dependency, as did `mvn dependency:tree`.
    
    We can change it now though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message