flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chesnay Schepler <ches...@apache.org>
Subject Re: [DISCUSS] Release 1.3.0 RC1 (Non voting, testing release candidate)
Date Fri, 19 May 2017 10:29:24 GMT
Whoops, this is the PR for enabling the test: 
https://github.com/apache/flink/pull/3844

On 19.05.2017 12:14, Robert Metzger wrote:
> Thank you for all your input.
>
> @Chesnay, in your email you are pointing to the same PR twice:
> This PR fixes the compilation on Windows:  (reviewed once, most recent
> changes not reviewed)
> https://github.com/apache/flink/pull/3854
> This PR enables a test for savepoint compatibility: (nice to have, easy to
> review)
> https://github.com/apache/flink/pull/3854
>
> Also the "should define more than one task slot" thing is not important IMO.
>
> I think the "empty path on windows" thing is not a release blocker.
>
> --------------------------------------------------------------
>
> These are the issues mentioned in the thread that are still open and
> blockers:
> - Add nested serializers to config snapshots of composite serializers:
> https://github.com/apache/flink/pull/3937 has no review yet
> - FLINK-6610 <https://issues.apache.org/jira/browse/FLINK-6610> WebServer
> could not be created,when set the "jobmanager.web.submit.enable" to false
> - FLINK-6629 <https://issues.apache.org/jira/browse/FLINK-6629> ClusterClient
> cannot submit jobs to HA cluster if address not set in configuration
>
>
>
> On Fri, May 19, 2017 at 12:17 AM, Till Rohrmann <trohrmann@apache.org>
> wrote:
>
>> I might have found another blocker:
>> https://issues.apache.org/jira/browse/FLINK-6629.
>>
>> The issue is that the ClusterClient only allows to submit jobs to an HA
>> cluster if you have specified the JobManager's address in the
>> flink-conf.yaml or via the command line options. If no address is set, then
>> it fails completely. If the wrong address is set, which can easily happen
>> in an HA setting, then we are not able to find the proper connecting
>> address for the ActorSystem. This basically voids Flink's HA capabilities.
>>
>> Cheers,
>> Till
>>
>> On Thu, May 18, 2017 at 10:23 PM, Chesnay Schepler <chesnay@apache.org>
>> wrote:
>>
>>> The test document says that the default flink-conf.yml "should define
>> more
>>> than one task slot", but it currently configures exactly 1 task slot. Not
>>> sure if it is a typo in the doc though.
>>>
>>>
>>> On 18.05.2017 22:10, Chesnay Schepler wrote:
>>>
>>>> The start-cluster.sh script failed for me on Windows when executed in a
>>>> directory containing spaces.
>>>>
>>>> On 18.05.2017 20:47, Chesnay Schepler wrote:
>>>>
>>>>> FLINK-6610 should also be fixed; it is currently not possible to
>> disable
>>>>> web-submissions.
>>>>>
>>>>> On 18.05.2017 18:13, jincheng sun wrote:
>>>>>
>>>>>> Hi Robert,
>>>>>> I have some checks to do and some test improve PRs (
>>>>>> https://issues.apache.org/jira/browse/FLINK-6619) need be done soon.
>>>>>>
>>>>>> Best,
>>>>>> SunJincheng
>>>>>>
>>>>>> 2017-05-18 22:17 GMT+08:00 Greg Hogan <code@greghogan.com>:
>>>>>>
>>>>>> The following tickets for 1.3.0 have a PR in need of review:
>>>>>>> [FLINK-6582] [docs] Project from maven archetype is not buildable
by
>>>>>>> default
>>>>>>> [FLINK-6616] [docs] Clarify provenance of official Docker images
>>>>>>>
>>>>>>>
>>>>>>> On May 18, 2017, at 5:40 AM, Fabian Hueske <fhueske@gmail.com>
>> wrote:
>>>>>>>> I have a couple of PRs ready with bugfixes that I'll try
to get in
>> as
>>>>>>> well.
>>>>>>>
>>>>>>>> Should be done soon.
>>>>>>>>
>>>>>>>> 2017-05-18 11:24 GMT+02:00 Till Rohrmann <trohrmann@apache.org>:
>>>>>>>>
>>>>>>>> I'd like to get a fix in for
>>>>>>>>> https://issues.apache.org/jira/browse/FLINK-6612. This
can
>> basically
>>>>>>>>> thwart
>>>>>>>>> Flink's recovery capabilities.
>>>>>>>>>
>>>>>>>>> On Thu, May 18, 2017 at 11:13 AM, Chesnay Schepler <
>>>>>>>>> chesnay@apache.org>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> This PR reduces logging noise a bit: (got +1 to merge)
>>>>>>>>>> https://github.com/apache/flink/pull/3917
>>>>>>>>>>
>>>>>>>>>> This PR fixes the compilation on Windows:  (reviewed
once, most
>>>>>>>>>> recent
>>>>>>>>>> changes not reviewed)
>>>>>>>>>> https://github.com/apache/flink/pull/3854
>>>>>>>>>>
>>>>>>>>>> This PR enables a test for savepoint compatibility:
(nice to have,
>>>>>>>>>> easy
>>>>>>>>>>
>>>>>>>>> to
>>>>>>>>>
>>>>>>>>>> review)
>>>>>>>>>> https://github.com/apache/flink/pull/3854
>>>>>>>>>>
>>>>>>>>>> These 2 PRs fix minor issues with metrics: (trivial
review, both
>>>>>>>>>> one-liners)
>>>>>>>>>> https://github.com/apache/flink/pull/3906
>>>>>>>>>> https://github.com/apache/flink/pull/3907
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 18.05.2017 10:52, Robert Metzger wrote:
>>>>>>>>>>
>>>>>>>>>> I will.
>>>>>>>>>>> Actually I had it already on my radar because
its one of the
>> three
>>>>>>>>>>> remaining blockers.
>>>>>>>>>>>
>>>>>>>>>>> Your JIRA has already a PR so I guess its on
a good track, for
>> the
>>>>>>>>>> other
>>>>>>>> blockers, I think its fine to release without having them
fixed.
>>>>>>>>>>> Is there anything else we need to get into the
1.3.0 release?
>>>>>>>>>>> Otherwise, I would soon create the first voting
RC.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Wed, May 17, 2017 at 8:49 PM, Eron Wright
<
>> eronwright@gmail.com
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Robert, please add FLINK-6606 to the list of
JIRAs that you're
>>>>>>>>>>>
>>>>>>>>>> tracking,
>>>>>>>> thanks.
>>>>>>>>>>>> On Tue, May 16, 2017 at 8:30 AM, Robert Metzger
<
>>>>>>>>>>>> rmetzger@apache.org
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> I totally forgot to post a document with
testing tasks in the
>> RC0
>>>>>>>>>>> thread,
>>>>>>>>>> so I'll do it in the RC1 thread.
>>>>>>>>>>>>> Please use this document:
>>>>>>>>>>>>> https://docs.google.com/document/d/11WCfV15VwQNF-
>>>>>>>>>>>>> Rar4E0RtWiZw1ddEbg5WWf4RFSQ_2Q/edit#
>>>>>>>>>>>>>
>>>>>>>>>>>>> If I have the feeling that not enough
people are seeing the
>>>>>>>>>>>>>
>>>>>>>>>>>> document,
>>>>>>>> I'll
>>>>>>>>>>>> write a dedicated email to user@ and dev@
:)
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Tue, May 16, 2017 at 9:26 AM, Robert
Metzger <
>>>>>>>>>>>>>
>>>>>>>>>>>> rmetzger@apache.org>
>>>>>>>> wrote:
>>>>>>>>>>>>> Thanks for the pointer. I'll keep an
eye on the JIRA.
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I've gone through the JIRAs tagged
with 1.3.0 yesterday to
>>>>>>>>>>>>>> create a
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> list
>>>>>>>>>>>>> of new features in 1.3. Feel free to
add more / change it in
>> the
>>>>>>>>>>>> wiki:
>>>>>>>> https://cwiki.apache.org/confluence/display/FLINK/
>>>>>>>>>>>>>> Flink+Release+and+Feature+Plan#FlinkReleaseandFeaturePlan-
>> Flink1.3
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Mon, May 15, 2017 at 10:29 PM,
Gyula Fóra <
>>>>>>>>>>>>>> gyula.fora@gmail.com
>>>>>>>>>>>>>>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks Robert,
>>>>>>>>>>>>>>> Just for the record I think there
are still some problems
>> with
>>>>>>>>>>>>>>> incremental
>>>>>>>>>>>>>> snapshots, I think Stefan is still
working on it.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I added some comments to https://issues.apache.org/
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> jira/browse/FLINK-6537
>>>>>>>>>>>>>> Gyula
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Robert Metzger <rmetzger@apache.org>
ezt írta (időpont:
>> 2017.
>>>>>>>>>>>>>> máj.
>>>>>>>> 15.,
>>>>>>>>>>>>> H,
>>>>>>>>>>>>>
>>>>>>>>>>>>>> 19:41):
>>>>>>>>>>>>>>> Hi Devs,
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> This is the second non-voting
RC. The last RC had some big
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> issues,
>>>>>>>> making
>>>>>>>>>>>>>>> it hard to start Flink locally.
I hope this RC proves to be
>>>>>>>>>>>>>>>> more
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> stable.
>>>>>>>>>>>>>> I hope to create the first voting
RC by end of this week.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> ------------------------------------------------------------
>>>>>>>>>>>>>>>> ---------
>>>>>>>>>>>>>> The release commit is 3659a82f553fedf8afe8b5fae75922
>> 075fe17e85
>>>>>>>>>>>>>> The artifacts are located here:
>>>>>>>>>>>>>>>> http://people.apache.org/~rmetzger/flink-1.3.0-rc1/
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> The maven staging repository
is here:
>>>>>>>>>>>>>>>> https://repository.apache.org/content/repositories/
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> orgapacheflink-1119
>>>>>>>>>>>>>> ------------------------------------------------------------
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> ---------
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Happy testing!
>>>>>>>>>>>>>> Regards,
>>>>>>>>>>>>>>>> Robert
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>
>>>>


Mime
View raw message