Mailing-List: contact dev-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Subject: Re: [VOTE] Release Apache Flink 1.2.1 (RC1)
To: dev@flink.apache.org
References: <CAGr9p8Dy4AhZqNJx_QmO+7O4voT=rinX7gXHmH0MjWr2W_tpkA@mail.gmail.com>
 <CAKiyyaFT+3FyKAbHMijJnPvHOt_hHTLsTj3OhaAxXMwymGk6cw@mail.gmail.com>
 <16ABE58F-592A-4D9B-A00C-1287619C0C0B@apache.org>
 <CAKiyyaFOweyaiR-wk6M65QRofrG1oTCdCiJzetixWwH4+7byMA@mail.gmail.com>
 <F28F841E-C968-4A42-B239-428BA4C24BB8@apache.org> <58D8E26F.30900@apache.org>
 <CAHpOOhG2=0qgYHC_57Z6w1kVDL65XSWm12m+36CA-Q3SAu0Qgw@mail.gmail.com>
 <CAGr9p8CY9Q5nn5wtb4RcNfrbOEoRvm1kOr1stn9fQDinsxkFqg@mail.gmail.com>
From: Timo Walther <twalthr@apache.org>
Message-ID: <be5a2827-8c05-a721-b4df-292fce644e56@apache.org>
Date: Wed, 29 Mar 2017 17:35:30 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CAGr9p8CY9Q5nn5wtb4RcNfrbOEoRvm1kOr1stn9fQDinsxkFqg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
archived-at: Wed, 29 Mar 2017 15:35:41 -0000

A user reported that all tumbling and slinding window assigners contain 
a pretty obvious bug about offsets.

https://issues.apache.org/jira/browse/FLINK-6214

I think we should also fix this for 1.2.1. What do you think?

Regards,
Timo


Am 29/03/17 um 11:30 schrieb Robert Metzger:
> Hi Haohui,
> I agree that we should fix the parallelism issue. Otherwise, the 1.2.1
> release would introduce a new bug.
>
> On Tue, Mar 28, 2017 at 11:59 PM, Haohui Mai <ricetons@gmail.com> wrote:
>
>> -1 (non-binding)
>>
>> We recently found out that all jobs submitted via UI will have a
>> parallelism of 1, potentially due to FLINK-5808.
>>
>> Filed FLINK-6209 to track it.
>>
>> ~Haohui
>>
>> On Mon, Mar 27, 2017 at 2:59 AM Chesnay Schepler <chesnay@apache.org>
>> wrote:
>>
>>> If possible I would like to include FLINK-6183 & FLINK-6184 as well.
>>>
>>> They fix 2 metric-related issues that could arise when a Task is
>>> cancelled very early. (like, right away)
>>>
>>> FLINK-6183 fixes a memory leak where the TaskMetricGroup was never closed
>>> FLINK-6184 fixes a NullPointerExceptions in the buffer metrics
>>>
>>> PR here: https://github.com/apache/flink/pull/3611
>>>
>>> On 26.03.2017 12:35, Aljoscha Krettek wrote:
>>>> I opened a PR for FLINK-6188: https://github.com/apache/
>> flink/pull/3616
>>> <https://github.com/apache/flink/pull/3616>
>>>> This improves the previously very sparse test coverage for
>>> timestamp/watermark assigners and fixes the bug.
>>>>> On 25 Mar 2017, at 10:22, Ufuk Celebi <uce@apache.org> wrote:
>>>>>
>>>>> I agree with Aljoscha.
>>>>>
>>>>> -1 because of FLINK-6188
>>>>>
>>>>>
>>>>> On Sat, Mar 25, 2017 at 9:38 AM, Aljoscha Krettek <
>> aljoscha@apache.org>
>>> wrote:
>>>>>> I filed this issue, which was observed by a user:
>>> https://issues.apache.org/jira/browse/FLINK-6188
>>>>>> I think that’s blocking for 1.2.1.
>>>>>>
>>>>>>> On 24 Mar 2017, at 18:57, Ufuk Celebi <uce@apache.org> wrote:
>>>>>>>
>>>>>>> RC1 doesn't contain Stefan's backport for the Asynchronous snapshots
>>>>>>> for heap-based keyed state that has been merged. Should we create
>> RC2
>>>>>>> with that fix since the voting period only starts on Monday? I think
>>>>>>> it would only mean rerunning the scripts on your side, right?
>>>>>>>
>>>>>>> – Ufuk
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Mar 24, 2017 at 3:05 PM, Robert Metzger <
>> rmetzger@apache.org>
>>> wrote:
>>>>>>>> Dear Flink community,
>>>>>>>>
>>>>>>>> Please vote on releasing the following candidate as Apache Flink
>>> version 1.2
>>>>>>>> .1.
>>>>>>>>
>>>>>>>> The commit to be voted on:
>>>>>>>> *732e55bd* (*
>>> http://git-wip-us.apache.org/repos/asf/flink/commit/732e55bd
>>>>>>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/732e55bd>*)
>>>>>>>>
>>>>>>>> Branch:
>>>>>>>> release-1.2.1-rc1
>>>>>>>>
>>>>>>>> The release artifacts to be voted on can be found at:
>>>>>>>> *http://people.apache.org/~rmetzger/flink-1.2.1-rc1/
>>>>>>>> <http://people.apache.org/~rmetzger/flink-1.2.1-rc1/>*
>>>>>>>>
>>>>>>>> The release artifacts are signed with the key with fingerprint
>>> D9839159:
>>>>>>>> http://www.apache.org/dist/flink/KEYS
>>>>>>>>
>>>>>>>> The staging repository for this release can be found at:
>>>>>>>>
>>> https://repository.apache.org/content/repositories/orgapacheflink-1116
>>>>>>>> -------------------------------------------------------------
>>>>>>>>
>>>>>>>>
>>>>>>>> The vote ends on Wednesday, March 29, 2017, 3pm CET.
>>>>>>>>
>>>>>>>>
>>>>>>>> [ ] +1 Release this package as Apache Flink 1.2.1
>>>>>>>> [ ] -1 Do not release this package, because ...
>>>