flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "canbinzheng (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FLINK-6132) Remove redundant code in CliFrontend.java
Date Mon, 20 Mar 2017 16:16:41 GMT
canbinzheng created FLINK-6132:
----------------------------------

             Summary: Remove redundant code in CliFrontend.java
                 Key: FLINK-6132
                 URL: https://issues.apache.org/jira/browse/FLINK-6132
             Project: Flink
          Issue Type: Improvement
          Components: Client
            Reporter: canbinzheng
            Priority: Minor


Look at the switch case block in method parseParameters of CliFrontend.java. 

		// do action
		switch (action) {
			case ACTION_RUN:
				return CliFrontend.this.run(params);
			case ACTION_LIST:
				return list(params);
			case ACTION_INFO:
				return info(params);
			case ACTION_CANCEL:
				return cancel(params);
			case ACTION_STOP:
				return stop(params);
			case ACTION_SAVEPOINT:
				return savepoint(params);
It's better to change the first case return clause 
from:
      return CliFrontend.this.run(params);
to:
      return run(params);




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message