flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Rohrmann <trohrm...@apache.org>
Subject Re: [DISCUSS] Code style / checkstyle
Date Wed, 22 Feb 2017 10:48:47 GMT
I think that not enforcing a code style is as good as not having any code
style to be honest. Having an IntelliJ or Eclipse profile is nice and some
people will probably use it, but my gut feeling is that the majority won't
notice it.

Cheers,
Till

On Wed, Feb 22, 2017 at 11:15 AM, Ufuk Celebi <uce@apache.org> wrote:

> Kurt's proposal sounds reasonable.
>
> What about the following:
> - We try to capture the current style in an code style configuration
> (for IntelliJ and maybe Eclipse)
> - We provide that on the website for contributors to download
> - We don't enforce it, but new contributions and changes are free to
> format with this style as changes happen
>
> Practically speaking, this should not change much except maybe the
> import order or whitespace after certain keywords, etc.
>
>
> On Wed, Feb 22, 2017 at 4:48 AM, Kurt Young <ykt836@gmail.com> wrote:
> > +1 to provide a unified code style for both java and scala.
> >
> > -1 to adjust all the existing code to the new style in one step. The
> code's
> > history contains very helpful information which can help
> > develops to understand why these codes are added, which jira is related.
> > This information is too valuable to lose. I think we can
> > do the reformat thing step by step, each time when the codes being
> changed,
> > we can adopt them to the new style.
> > IMHO this is also the reason why the unified code style is important.
> >
> >
> > Best,
> > Kurt
> >
> > On Wed, Feb 22, 2017 at 5:50 AM, Dawid Wysakowicz <
> > wysakowicz.dawid@gmail.com> wrote:
> >
> >> Hi,
> >> I would like to resurrect the discussing ([1]
> >> <http://apache-flink-mailing-list-archive.1008284.n3.
> >> nabble.com/Code-style-guideline-for-Scala-td7526.html>
> >> , [2]
> >> <http://apache-flink-mailing-list-archive.1008284.n3.
> >> nabble.com/Intellij-code-style-td11092.html>)
> >> about creating unified code style(that could be imported to at least
> >> IntelliJ and Eclipse) and corresponding stricter checkstyle rules.
> >>
> >> I know that the hardest part is to adjust the existing code to the new
> >> checkstyle rules. Do you believe it would be worth the effort? All
> >> suggestions are welcome.
> >>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message