Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4BC00200C02 for ; Fri, 20 Jan 2017 16:42:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4A73F160B48; Fri, 20 Jan 2017 15:42:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 94F2B160B39 for ; Fri, 20 Jan 2017 16:42:06 +0100 (CET) Received: (qmail 99437 invoked by uid 500); 20 Jan 2017 15:42:05 -0000 Mailing-List: contact dev-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list dev@flink.apache.org Received: (qmail 99421 invoked by uid 99); 20 Jan 2017 15:42:05 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jan 2017 15:42:05 +0000 Received: from mail-it0-f43.google.com (mail-it0-f43.google.com [209.85.214.43]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 738161A06AA for ; Fri, 20 Jan 2017 15:42:05 +0000 (UTC) Received: by mail-it0-f43.google.com with SMTP id r185so23411786ita.0 for ; Fri, 20 Jan 2017 07:42:05 -0800 (PST) X-Gm-Message-State: AIkVDXIZU0SEvT9tTKI+LVfCVpovEqq7xkdTwuBgRxr4sdtUWwIOQqVmjbMKTDW6dEpUyFYMHMkVQvfSP1wFdw== X-Received: by 10.36.10.3 with SMTP id 3mr3946621itw.108.1484926924836; Fri, 20 Jan 2017 07:42:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.19.101 with HTTP; Fri, 20 Jan 2017 07:42:04 -0800 (PST) In-Reply-To: References: <20FDA2ED-A04B-4FE4-A901-009F6878F0BC@kth.se> From: Stephan Ewen Date: Fri, 20 Jan 2017 16:42:04 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [DISCUSS] (Not) tagging reviewers To: "dev@flink.apache.org" Content-Type: multipart/alternative; boundary=001a1143e4cedf76a00546887d08 archived-at: Fri, 20 Jan 2017 15:42:07 -0000 --001a1143e4cedf76a00546887d08 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable @Alexey - Pull Requests backlog is going pretty crazy, I agree. That is not because the committers are not working on pull requests, there is simply so many of them. We are looking for new committers (and discussing in the PMC). Tagging is not going to make this better, I believe. It may make it worse, because it discourages non-tagged community members from picking up a pull request. On Mon, Jan 16, 2017 at 4:54 PM, Anton Solovev wrote: > Hi, Alexey > > I will check abandoned PRs to reduce obviously outdated ones and add them > to a cleanup list https://issues.apache.org/jira/browse/FLINK-5384 > > > -----Original Message----- > From: Alexey Demin [mailto:diominay@gmail.com] > Sent: Monday, January 16, 2017 5:05 PM > To: dev@flink.apache.org > Subject: Re: [DISCUSS] (Not) tagging reviewers > > Hi all > > View from my prospective: > in middle of summer - 150 PR > in middle of autumn - 180 > now 206. > > This is mix of bugfixes and improvements. > I understand that work on new features important, but when small and > trivial fixes stay in states of PR more then 2-3 month, then all users > think about changing engine on other product. > > Only way push people to merge this fixes in master it's tags. > > I don't speak about big changes, only about small and trivial with review > less then 5 min. > > Features important, but if this features work incorrect, then user can > select more stability product without any hesitation. > > Thanks > Alexey Diomin > > > > 2017-01-16 16:36 GMT+04:00 Ufuk Celebi : > > > On 16 January 2017 at 12:59:04, Paris Carbone (parisc@kth.se) wrote: > > > > Though, when someone has started reviewing a PR and shows interest > > > it probably makes sense to finish doing so. Wouldn=E2=80=99t tagging = be > > > acceptable there? > > > In those case tagging triggers direct notifications, so that people > > > already involved in a conversation get reminded and answer pending > > > questions. > > > > I think that's totally fine Paris since it is more of a reminder in > > that case. > > > > Stephan is referring to PRs that have a last line in the description > > like "@XZY for review please". > > > > =E2=80=93 Ufuk > > > > > > > --001a1143e4cedf76a00546887d08--