flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Ewen <se...@apache.org>
Subject Re: [DISCUSS] (Not) tagging reviewers
Date Mon, 16 Jan 2017 13:58:57 GMT
Thanks for the comments.

@Paris - Ufuk has it right, tagging as a reminder (or just because it helps
with referring to the comment from a specific reviewer) makes total sense
to me, I would keep doing that.


On Mon, Jan 16, 2017 at 1:36 PM, Ufuk Celebi <uce@apache.org> wrote:

> On 16 January 2017 at 12:59:04, Paris Carbone (parisc@kth.se) wrote:
> > > Though, when someone has started reviewing a PR and shows interest
> > it probably makes sense to finish doing so. Wouldn’t tagging
> > be acceptable there?
> > In those case tagging triggers direct notifications, so that
> > people already involved in a conversation get reminded and answer
> > pending questions.
>
> I think that's totally fine Paris since it is more of a reminder in that
> case.
>
> Stephan is referring to PRs that have a last line in the description like
> "@XZY for review please".
>
> – Ufuk
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message