flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fabian Hueske <fhue...@gmail.com>
Subject Re: [DISCUSS] (Not) tagging reviewers
Date Fri, 20 Jan 2017 23:52:46 GMT
Hi Haohui,

reviewing pull requests is a great way of contributing to the community!

I am not aware of specific instructions for the review process. The are
some dos and don'ts on our "contribute code" page [1] that should be
considered. Apart from that, I think the best way to start is to become
familiar with a certain part of the code base (reading code, contributing)
and then to look out for pull requests that address the part you are
familiar with.

The review does not have to cover all aspects of a PR (a committer will
have a look as well), but from my personal experience the effort to review
a PR is often much lower if some other person has had a look at it already
and gave feedback.
I think this can help a lot to reduce the review "load" on the committers.
Maybe you find some contributors who are interested in the same components
as you and you can start reviewing each others code.

Thanks,
Fabian

[1] http://flink.apache.org/contribute-code.html#coding-guidelines


2017-01-20 23:02 GMT+01:00 jincheng sun <sunjincheng121@gmail.com>:

> I totally agree with all of your ideas.
>
>
>
>
>
>
>
>
>
>
> Best wishes,
>
>
>
> SunJincheng.
>
> Stephan Ewen <sewen@apache.org>于2017年1月16日 周一19:42写道:
>
> > Hi!
> >
> >
> >
> > I have seen that recently many pull requests designate reviews by writing
> >
> > "@personA review please" or so.
> >
> >
> >
> > I am personally quite strongly against that, I think it hurts the
> community
> >
> > work:
> >
> >
> >
> >   - The same few people get usually "designated" and will typically get
> >
> > overloaded and often not do the review.
> >
> >
> >
> >   - At the same time, this discourages other community members from
> looking
> >
> > at the pull request, which is totally undesirable.
> >
> >
> >
> >   - In general, review participation should be "pull based" (person
> decides
> >
> > what they want to work on) not "push based" (random person pushes work to
> >
> > another person). Push-based just creates the wrong feeling in a community
> >
> > of volunteers.
> >
> >
> >
> >   - In many cases the designated reviews are not the ones most
> >
> > knowledgeable in the code, which is understandable, because how should
> >
> > contributors know whom to tag?
> >
> >
> >
> >
> >
> > Long story short, why don't we just drop that habit?
> >
> >
> >
> >
> >
> > Greetings,
> >
> > Stephan
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message