flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinkui Shi <shijinkui...@163.com>
Subject Re: TestBaseUtils refactoring
Date Thu, 26 Jan 2017 06:33:08 GMT
hi, all

UT and CT have clear boundary and consensus of opinion:
1. UT and CT separated.  surefire plugin have two different execution for CT and UT
2. Temporary file creating and destroy should be unified with TemporaryFolder. 
     FLINK-5546 has change the java.io <http://java.io/>.tmpdir to target directory.
     I think Stephan or other committer can replace temporary file management with TemporaryFolder
 in one issue or several sub-issues. There are so many test file need to be corrected.
3. should have clearly test suffix. For example: *.Test.java, *.Suite.scala used for UT; *ITCase.java,
*ITSuite.scala used for Scala.  FLINK-5546 has add java UT include clearly.

IMO, TestBaseUtils’ responsibility is not clear, suggesting:
1. correct the tmp file creating with TemporaryFolder
2. all the static field should be modify, should not be final
3. what’s the responsibility of TestBaseUtils, use as base unit test or as base util class
of unit class? Util class should not be extends by unit test class.

Best,
Jinkui Shi

> On Jan 26, 2017, at 11:37, Jark Wu <wuchong.wc@alibaba-inc.com> wrote:
> 
> Hi Anton,
> 
> Thanks for bringing up this discussion. 
> 
> I think TestBaseUtils is a util class not a base class to extend. 
> All the methods in TestBaseUtils are static, that means we can 
> use any method directly without extend it.
> 
> Thanks, Jark
> 
>> 在 2017年1月26日,上午7:46,Anton Solovev <Anton_Solovev@epam.com>
写道:
>> 
>> Hello guys,
>> 
>> I think there is a sense to tear apart TestBaseUtils into a number of util classes
which it keeps them.
>> Because some test classes can't extend this base test class, but need in its result
checkers
>> 
>> Best,
>> Anton
>> 
>> 
> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message