flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Hogan <c...@greghogan.com>
Subject Re: Travis build broken on missing licenses
Date Wed, 07 Dec 2016 14:17:01 GMT
This was my mistake. The commit only involved web assets so I had tested
the runtime but had not run mvn verify. Also, I'm typically aware of the CI
status (receiving the emails for my own pull requests) but had failed to
note the failure of the license check on this PR.

On Wed, Dec 7, 2016 at 4:56 AM, Maximilian Michels <mxm@apache.org> wrote:

> Since the Rat plugin which fails the build runs in the first seconds
> of the build process, I wonder how that was not detected before
> merging the commit? :)
>
> On Wed, Dec 7, 2016 at 10:46 AM, Till Rohrmann <till.rohrmann@gmail.com>
> wrote:
> > Thanks Marton.
> >
> > On Wed, Dec 7, 2016 at 8:24 AM, Fabian Hueske <fhueske@gmail.com> wrote:
> >
> >> Thanks Marton!
> >>
> >> 2016-12-07 2:49 GMT+01:00 Márton Balassi <balassi.marton@gmail.com>:
> >>
> >> > Done, my Travis build came in all green:
> >> >
> >> > https://travis-ci.org/mbalassi/flink/builds/181809550
> >> >
> >> > The hotfix is pushed.
> >> >
> >> > On Tue, Dec 6, 2016 at 5:08 PM, Márton Balassi <
> balassi.marton@gmail.com
> >> >
> >> > wrote:
> >> >
> >> > > The travis build is currently broken, if noone has fixed it yet
> then I
> >> > > will push the fix for it.
> >> > >
> >> > > https://travis-ci.org/apache/flink/builds/181765492
> >> > >
> >> > > The following files have missing licenses:
> >> > >
> >> > > flink-runtime-web/web-dashboard/assets/images/browserconfig.xml
> >> > > flink-runtime-web/web-dashboard/assets/images/manifest.json
> >> > > flink-runtime-web/web-dashboard/assets/images/safari-pinned-tab.svg
> >> > >
> >> > > I will add them as exceptions as they are referring to the images.
> >> > >
> >> > > Please double check Travis before pushing commits to master.
> >> > >
> >> > > Best,
> >> > >
> >> > > Marton
> >> > >
> >> >
> >>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message