Mailing-List: contact dev-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Subject: Re: Move Row, RowInputFormat to core package
To: dev@flink.apache.org
References: <HE1PR03MB1305944AB4A88A955F1D49C6F3B60@HE1PR03MB1305.eurprd03.prod.outlook.com>
From: Timo Walther <twalthr@apache.org>
Message-ID: <c90af1ff-8af3-19af-256a-60c683945efd@apache.org>
Date: Fri, 25 Nov 2016 14:30:10 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <HE1PR03MB1305944AB4A88A955F1D49C6F3B60@HE1PR03MB1305.eurprd03.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
archived-at: Fri, 25 Nov 2016 13:30:15 -0000

Hi Anton,

I would also support the idea of moving Row and RowTypeInfo to Flink 
core. I think there are many real-world use cases where a 
variable-length record that supports null values is required. However, I 
think that those classes needs to be reworked before. They should not 
depend on Scala-related things.

RowTypeInfo should not inherit from CaseClassTypeInfo, the current 
solution with the dummy field names is a hacky solution anyway. Row 
should not inherit from Scala classes.

Regards,
Timo

Am 24/11/16 um 16:46 schrieb Anton Solovev:
> Hello,
>
>
>
> In Scala case classes can store huge count of fields, it's really helpful for reading wide csv files, but It uses only in table api.
>
> what about this issue (https://issues.apache.org/jira/browse/FLINK-2186), should we use table api in machine learning library?
>
> To solve the issue #readCsvFile can generate RowInputFormat.
>
> For commodity I added another one constructor in RowTypeInfo (https://github.com/apache/flink/compare/master...tonycox:FLINK-2186-x)
>
> What do you think about add some scala and moving Row to Flink core?
>