flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FLINK-4938) Unnecessary update() call for Views to be removed in ViewUpdater#run()
Date Thu, 27 Oct 2016 00:21:58 GMT
Ted Yu created FLINK-4938:
-----------------------------

             Summary: Unnecessary update() call for Views to be removed in ViewUpdater#run()
                 Key: FLINK-4938
                 URL: https://issues.apache.org/jira/browse/FLINK-4938
             Project: Flink
          Issue Type: Bug
            Reporter: Ted Yu
            Priority: Minor


{code}
      for (View toUpdate : this.views) {
        toUpdate.update();
      }

      synchronized (lock) {
        views.addAll(toAdd);
        toAdd.clear();
        views.removeAll(toRemove);
{code}
For View's in toRemove, update() call is not needed. See earlier javadoc:
{code}
   * Notifies this ViewUpdater of a metric that should no longer be regularly updated.
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message