flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ufuk Celebi <...@apache.org>
Subject Re: Releasing Flink 1.1.3
Date Wed, 05 Oct 2016 16:53:51 GMT
Thanks for your effort!

I'm going to kick off the build now. :-)

On Wed, Oct 5, 2016 at 5:59 PM, Maximilian Michels <mxm@apache.org> wrote:
> Kostas PR https://github.com/apache/flink/pull/2593 is merged. I think
> we're good to go.
>
> On Wed, Oct 5, 2016 at 3:44 PM, Maximilian Michels <mxm@apache.org> wrote:
>> I'll merge https://github.com/apache/flink/pull/2548 for the release.
>> It's cosmetic but it avoids a NPE in case the user jar doesn't contain
>> Flink jobs.
>>
>> On Wed, Oct 5, 2016 at 12:59 PM, Kostas Kloudas
>> <k.kloudas@data-artisans.com> wrote:
>>> Hi Ufuk,
>>>
>>> Thanks for being the release manager.
>>>
>>> There is already an open PR under review for the Continuous File Sources.
>>>
>>> Kostas
>>>
>>>> On Oct 4, 2016, at 11:25 PM, Ufuk Celebi <uce@apache.org> wrote:
>>>>
>>>> Thanks for your prompt responses.
>>>>
>>>> Except for the streaming file source issues, all mentioned issues are
>>>> addressed. As soon as the last one is in, I can kick off the first RC.
>>>>
>>>> @Kostas, Stephan: you didn't mention anything here or in the PR. Did
>>>> you have time to work on this? :)
>>>>
>>>> – Ufuk
>>>>
>>>> On Tue, Oct 4, 2016 at 7:08 PM, Stephan Ewen <sewen@apache.org> wrote:
>>>>> Concerning the Pull Requests about Kafka 0.8 offset committing:
>>>>>
>>>>> They look good, but I would actually like to not merge them to Flink
1.1.3,
>>>>> as they may result in slightly changed behavior for users of Kafka 0.8
>>>>>
>>>>> The crucial fix (Kafka 0.9) is already in, so on the Kafka side are are
>>>>> good to go, in my opinion.
>>>>>
>>>>> Greetings,
>>>>> Stephan
>>>>>
>>>>>
>>>>> On Tue, Oct 4, 2016 at 12:24 PM, Tzu-Li (Gordon) Tai <tzulitai@apache.org>
>>>>> wrote:
>>>>>
>>>>>> Thanks Ufuk for stepping up as RM!
>>>>>>
>>>>>> Regarding whether FLINK-4723 / FLINK-4727 should be included:
>>>>>> The failing test on PR #2580 is unrelated to the change.
>>>>>> However, I think it’s reasonable to skip them if we’re aiming
to get a RC
>>>>>> out today, as they’ll need more time for reviewing.
>>>>>> Not including them will only pose problems if users are consuming
Kafka
>>>>>> topics across Flink’s connector & high-level Kafka consumers
when using
>>>>>> Kafka 0.8.
>>>>>>
>>>>>> We don’t really have users reporting problems on this yet, so I’d
say it’s
>>>>>> ok to skip them for 1.1.3 :)
>>>>>>
>>>>>>
>>>>>> On October 4, 2016 at 6:12:06 PM, Fabian Hueske (fhueske@gmail.com)
wrote:
>>>>>>
>>>>>> Thanks Ufuk for stepping up as release manager!
>>>>>>
>>>>>> Yes, I will backport the fix for FLINK-4311 to Flink 1.1.3 and merge
it
>>>>>> today.
>>>>>>
>>>>>> 2016-10-04 12:07 GMT+02:00 Ufuk Celebi <uce@apache.org>:
>>>>>>
>>>>>>> If there are no objections I would like to be the release manager
for
>>>>>>> this release.
>>>>>>>
>>>>>>> Futhermore, I would like to add FLINK-4732 (Maven junction plugin
>>>>>>> security issue) to the list of fixes for this release. Other
than
>>>>>>> that, I think the list in this thread is good and we should now
focus
>>>>>>> on getting a RC out. I would really like to do this today in
order to
>>>>>>> start testing.
>>>>>>>
>>>>>>> The current state of affairs is as follows:
>>>>>>>
>>>>>>> - FLINK-4732 (Maven junction plugin security issue) has a fix
in
>>>>>>> https://github.com/apache/flink/pull/2586. @Max: Can you merge
this
>>>>>>> today?
>>>>>>>
>>>>>>> - FLINK-4702 (Kafka async offset commit) has been merged.
>>>>>>>
>>>>>>> - FLINK-4329 (streaming file sources) has a fix in
>>>>>>> https://github.com/apache/flink/pull/2546, which needs both another
>>>>>>> round of review and backporting to 1.1. Kostas Kloudas is working
on
>>>>>>> this with Stephan as reviewer. @Stephan, Kostas: Do you think
that
>>>>>>> this can be merged today?
>>>>>>>
>>>>>>> - FLINK-4311 (TableInputFormat) has a fix in
>>>>>>> https://github.com/apache/flink/pull/2330 and is good to merge
>>>>>>> according to Fabian. @Fabian: Can you merge this today?
>>>>>>>
>>>>>>> - FLINK-4727 (https://github.com/apache/flink/pull/2580) and
>>>>>>> FLINK-4723 (https://github.com/apache/flink/pull/2585) have been
>>>>>>> issued recently and look like they could be skipped for 1.1.3
(given
>>>>>>> that there is a test failure in #2580). I'm not too familiar
with the
>>>>>>> Kafka connector though. @Tzu-Li, Stephan: Can you please comment
on
>>>>>>> both of these whether they need to go in?
>>>>>>>
>>>>>>> – Ufuk
>>>>>>>
>>>>>>
>>>>>>
>>>

Mime
View raw message