flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FLINK-4701) Unprotected access to cancelables in StreamTask
Date Tue, 27 Sep 2016 18:04:20 GMT
Ted Yu created FLINK-4701:
-----------------------------

             Summary: Unprotected access to cancelables in StreamTask
                 Key: FLINK-4701
                 URL: https://issues.apache.org/jira/browse/FLINK-4701
             Project: Flink
          Issue Type: Bug
            Reporter: Ted Yu
            Priority: Minor


In performCheckpoint():
{code}
                                AsyncCheckpointRunnable asyncCheckpointRunnable = new AsyncCheckpointRunnable(
                                                "checkpoint-" + checkpointId + "-" + timestamp,
                                                this,
                                                cancelables,
                                                chainedStateHandles,
                                                keyGroupsStateHandleFuture,
                                                checkpointId,
                                                bytesBufferedAlignment,
                                                alignmentDurationNanos,
                                                syncDurationMillis,
                                                endOfSyncPart);

                                synchronized (cancelables) {
                                        cancelables.add(asyncCheckpointRunnable);
                                }
{code}
Construction of AsyncCheckpointRunnable should be put under the synchronized block of cancelables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message