flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Hogan (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FLINK-4594) Validate lower bound in MathUtils.checkedDownCast
Date Wed, 07 Sep 2016 19:32:21 GMT
Greg Hogan created FLINK-4594:

             Summary: Validate lower bound in MathUtils.checkedDownCast
                 Key: FLINK-4594
                 URL: https://issues.apache.org/jira/browse/FLINK-4594
             Project: Flink
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.2.0
            Reporter: Greg Hogan
            Assignee: Greg Hogan
            Priority: Trivial

{{MathUtils.checkedDownCast}} only compares against the upper bound {{Integer.MAX_VALUE}},
which has worked with current usage. 

Rather than adding a second comparison we can replace

if (value > Integer.MAX_VALUE) {

with a cast and check

if ((int)value != value) { ...

This message was sent by Atlassian JIRA

View raw message