flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shijinkui <shijin...@huawei.com>
Subject 答复: [discuss] merge module flink-yarn and flink-yarn-test
Date Thu, 22 Sep 2016 00:58:25 GMT
Hi, Stephan

Thanks for your reply. 

In my mind, Maven-shade-plugin and sbt-assembly both default exclude test code for the fat
jar.

In fact, unit tests are use to test the main code, ensure our code logic fit our expect .
This is general convention. I think. Flink has be a top apache project. We shouldn't be special.
We're programmer, should be professional.

Even more, there are `flink-tes-utils-parent` and `flink-tests` module, what's the relation
between them. 

I have to ask why they are exist? Where is the start of such confusion modules? 

I think we shouldn't do nothing for this. Code and design should be comfortable.

Thanks

From Jinkui Shi

-----邮件原件-----
发件人: Stephan Ewen [mailto:sewen@apache.org] 
发送时间: 2016年9月21日 22:19
收件人: dev@flink.apache.org
主题: Re: [discuss] merge module flink-yarn and flink-yarn-test

I would like Robert to comment on this.

I think there was a reason to have different modules, which had again something to do with
the Maven Shade Plugin Dependencies and shading really seem the trickiest thing in bigger
Java/Scala projects ;-)

On Wed, Sep 21, 2016 at 11:04 AM, shijinkui <shijinkui@huawei.com> wrote:

> Hi, All
>
> There too much module in the root. There are no necessary to separate 
> the test code from sub-module.
>
> I never see such design: two modules, one is main code, the other is 
> test code.
>
> Is there some special reason?
>
> From Jinkui Shi
>
Mime
  • Unnamed multipart/mixed (inline, None, 0 bytes)
View raw message