Mailing-List: contact dev-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
MIME-Version: 1.0
In-Reply-To: <CANC1h_uSsRtAkerd+ZApzO9yA9Xs-y5iSi=TFiwU5r5EEq2pkg@mail.gmail.com>
References: <CANC1h_uSsRtAkerd+ZApzO9yA9Xs-y5iSi=TFiwU5r5EEq2pkg@mail.gmail.com>
From: Robert Metzger <rmetzger@apache.org>
Date: Mon, 8 Aug 2016 16:45:25 +0200
Message-ID: <CAGr9p8BR_M2OHyD8hJgU4DmsGodPt_hvjk48_witDK4qW2vr-w@mail.gmail.com>
Subject: Re: [DISCUSS] API breaking change in DataStream Windows
To: "dev@flink.apache.org" <dev@flink.apache.org>
Content-Type: multipart/alternative; boundary=001a114faee4a6710205399078e9
archived-at: Mon, 08 Aug 2016 14:45:48 -0000

--001a114faee4a6710205399078e9
Content-Type: text/plain; charset=UTF-8

Thank you for bringing this discussion to the mailing list.

I agree with Chesnay's comment on GitHub that we should consider the
"casting option" as well. I don't think we should break the API if there is
a (admittedly ugly) work-around for those who run into the problem.
If we put the work-around into the JavaDocs and the DataStream API
documentation, everybody who is seriously blocked by this should find it.

For 2.0, we can break the API by changing the method signature.


On Mon, Aug 8, 2016 at 4:11 PM, Stephan Ewen <sewen@apache.org> wrote:

> Hi all!
>
> We have a problem in the *DataStream API* around Windows for *CoGroup* and
> *Join*.
> These operations currently do not allow to set a parallelism, which is a
> pretty heavy problem.
>
> To fix it properly, we need to change the return types of the coGroup() and
> join() operations, which *breaks the binary compatibility* - it* retains
> source compatibility*, though.
>
> The pull request with the change is:
> https://github.com/apache/flink/pull/2305
>
> There are very clumsy ways to work around this (custom casts in the user
> code or making the join() / coGroup() behave differently than the other
> operators) which we did not really think of as viable, because they would
> need to be changed again in the future once we pull the API straight
> (breaking even source compatibility then).
>
> *I would suggest to actually break the API* at that point (binary, not
> source) for *Flink 1.2* and add a big note in the release docs. An
> uncomfortable step, but the alternatives are quite bad, too.
>
> Have a look at what has been suggested in the pull request discussion and
> please let us know what you think about that so we can proceed.
>
> Greetings,
> Stephan
>

--001a114faee4a6710205399078e9--