flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neelesh Srinivas Salian (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FLINK-4278) Unclosed FSDataOutputStream in multiple files in the project
Date Thu, 28 Jul 2016 19:24:20 GMT
Neelesh Srinivas Salian created FLINK-4278:

             Summary: Unclosed FSDataOutputStream in multiple files in the project
                 Key: FLINK-4278
                 URL: https://issues.apache.org/jira/browse/FLINK-4278
             Project: Flink
          Issue Type: Bug
    Affects Versions: 1.0.3
            Reporter: Neelesh Srinivas Salian
            Assignee: Neelesh Srinivas Salian

After FLINK-4259, I did a check and found that the following files don't have the closing
of the FSDataOutputStream.

The following are the files and the corresponding methods missing the close() 
1) FSDataOutputStream.java adding a close method in the abstract class
2) FSStateBackend flush() and write() - closing the FSDataOutputStream
3) StringWriter.java write()
4) FileSystemStateStore putState() -  closing the FSDataOutputStream

5) HadoopDataOutputStream.java not too sure if this needs closing.
6) FileSystemStateStorageHelper.java store() need closing for both outStream and the ObjectOutputStream

The options to think would be to either close or use  IOUtils.closeQuietly() 

Any thoughts?

This message was sent by Atlassian JIRA

View raw message