Mailing-List: contact dev-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Tue, 17 May 2016 20:13:13 +0000 (UTC)
From: "Tatu Saloranta (JIRA)" <jira@apache.org>
To: dev@flink.apache.org
Message-ID: <JIRA.12970524.1463515976000.215136.1463515993559@Atlassian.JIRA>
In-Reply-To: <JIRA.12970524.1463515976000@Atlassian.JIRA>
References: <JIRA.12970524.1463515976000@Atlassian.JIRA> <JIRA.12970524.1463515976808@arcas>
Subject: [jira] [Created] (FLINK-3921) StringParser not specifying encoding
 to use
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 17 May 2016 20:13:16 -0000

Tatu Saloranta created FLINK-3921:
-------------------------------------

             Summary: StringParser not specifying encoding to use
                 Key: FLINK-3921
                 URL: https://issues.apache.org/jira/browse/FLINK-3921
             Project: Flink
          Issue Type: Improvement
          Components: Core
    Affects Versions: 1.0.3
            Reporter: Tatu Saloranta
            Priority: Minor


Looking at default `TypeSerializer` instances I noticed what looks like a minor flaw, unless I am missing something.
Whereas all other array serializers indicate that type is not immutable (since in Java, arrays are not immutable), `StringArraySerializer` has:

```
	@Override
	public boolean isImmutableType() {
		return true;
	}
```

and I think it should instead return `false`. I could create a PR, but seems like a small enough thing that issue report makes more sense.
I tried looking for deps to see if there's a test for this, but couldn't find one; otherwise could submit a test fix.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)