flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Flavio Pompermaier <pomperma...@okkam.it>
Subject Re: RequiredParameters vs ParameterTool
Date Wed, 11 May 2016 17:10:02 GMT
I know how it works, I just wanted to point out that that part could be
improved ad little bit since there are redundant functions and maybe the
name of the RequiredParameters is somehow misleading...maybe
ParameterToolHelper or ParameterToolUtils would be better...
On 11 May 2016 19:00, "Aljoscha Krettek" <aljoscha@apache.org> wrote:

I think RequiredParameters is meant to be used with ParameterTool. For
example, check out RequiredParametersTest.

On Wed, 11 May 2016 at 11:05 Flavio Pompermaier <pompermaier@okkam.it>
wrote:

> Hi flinkers,
> I was converting my parameter validation code to the new (and very useful)
> RequiredParameters APIs. However I faced some issue with its semantic and
I
> wanted to report my doubts to the community and see whether those APIs
> coould be improved or not.
>
> I started using RequiredParameters to manage and validate input parameters
> but immediately later I remebered that ParameterTool has its own
> getRequired and getXXX (Boolean, Integer,etc..) with the possibility of
> defaulting values.
> IMHO this creates some confusion because there are 2 classes in charge for
> the defaulting and the validation of parameters. Am I too picky?
>
> Best,
> Flavio
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message