flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chiwan Park <chiwanp...@apache.org>
Subject Re: Intellij code style
Date Fri, 13 May 2016 03:58:21 GMT
Please create a JIRA issue for this and send the PR with JIRA issue number.

Regards,
Chiwan Park

> On May 12, 2016, at 7:15 PM, Flavio Pompermaier <pompermaier@okkam.it> wrote:
> 
> Do I need to open also a Jira or just the PR?
> 
> On Thu, May 12, 2016 at 12:03 PM, Stephan Ewen <sewen@apache.org> wrote:
> 
>> Yes, please open a pull request for that.
>> 
>> On Thu, May 12, 2016 at 11:40 AM, Flavio Pompermaier <pompermaier@okkam.it
>>> 
>> wrote:
>> 
>>> If you're interested to I created an Eclipse version that should follows
>>> Flink coding rules..should I create a new JIRA for it?
>>> 
>>> On Thu, May 5, 2016 at 6:02 PM, Dawid Wysakowicz <
>>> wysakowicz.dawid@gmail.com
>>>> wrote:
>>> 
>>>> I opened JIRA: https://issues.apache.org/jira/browse/FLINK-3870. and
>>>> created PR both to flink and flink-web.
>>>> 
>>>> https://github.com/apache/flink/pull/1963
>>>> https://github.com/apache/flink-web/pull/20
>>>> 
>>>> I would be thankful for a review.
>>>> 
>>>> 2016-05-04 11:00 GMT+02:00 Fabian Hueske <fhueske@gmail.com>:
>>>> 
>>>>> Yes, please open a JIRA. Thanks!
>>>>> 
>>>>> 2016-05-04 10:16 GMT+02:00 Dawid Wysakowicz <
>>> wysakowicz.dawid@gmail.com
>>>>> :
>>>>> 
>>>>>> Sure, Will open PR shortly. Shall I create any JIRA issue?
>>>>>> 
>>>>>> 2016-05-04 9:28 GMT+02:00 Fabian Hueske <fhueske@gmail.com>:
>>>>>> 
>>>>>>> +1 for adding a template to the tools folder and linking it from
>>> the
>>>>>> coding
>>>>>>> guide lines!
>>>>>>> 
>>>>>>> 2016-05-04 6:08 GMT+02:00 Henry Saputra <henry.saputra@gmail.com
>>> :
>>>>>>> 
>>>>>>>> We could actually put this in the tools directory of the
source
>>> and
>>>>>> repo
>>>>>>>> and refer it from contribution guide.
>>>>>>>> 
>>>>>>>> @Dawid want to try to send Pull request for it?
>>>>>>>> 
>>>>>>>> On Thursday, April 28, 2016, Theodore Vasiloudis <
>>>>>>>> theodoros.vasiloudis@gmail.com> wrote:
>>>>>>>> 
>>>>>>>>> Do we plan to include something like this in the contribution
>>>> guide
>>>>>> as
>>>>>>>>> well?
>>>>>>>>> 
>>>>>>>>> On Thu, Apr 28, 2016 at 3:16 PM, Stefano Baghino <
>>>>>>>>> stefano.baghino@radicalbit.io <javascript:;>>
wrote:
>>>>>>>>> 
>>>>>>>>>> Awesome Dawid! Thanks for taking the time to do this.
:)
>>>>>>>>>> 
>>>>>>>>>> On Thu, Apr 28, 2016 at 1:45 PM, Dawid Wysakowicz
<
>>>>>>>>>> wysakowicz.dawid@gmail.com <javascript:;>>
wrote:
>>>>>>>>>> 
>>>>>>>>>>> Hi,
>>>>>>>>>>> 
>>>>>>>>>>> I tried to create a code style that would follow
Flink
>>>>>> code-style.
>>>>>>> It
>>>>>>>>> may
>>>>>>>>>>> be not "production" ready, but I think it can
be a good
>>>> start.
>>>>>>>>>>> Hope it will be useful for someone. Also I will
be glad
>> for
>>>> any
>>>>>>>>> comments
>>>>>>>>>>> on that.
>>>>>>>>>>> 
>>>>>>>>>>> 2016-04-10 13:59 GMT+02:00 Stephan Ewen <
>> sewen@apache.org
>>>>>>>>> <javascript:;>>:
>>>>>>>>>>> 
>>>>>>>>>>>> I don't know how close Phoenix' code style
is to Flink's
>>>>>> de-facto
>>>>>>>> code
>>>>>>>>>>>> style.
>>>>>>>>>>>> I would create one that reflects Flink's
de-facto code
>>>> style,
>>>>> so
>>>>>>>> that
>>>>>>>>>> the
>>>>>>>>>>>> formatter does not change everything...
>>>>>>>>>>>> 
>>>>>>>>>>>> On Sun, Apr 10, 2016 at 4:40 AM, Naveen Madhire
<
>>>>>>>>> vmadhire@umail.iu.edu <javascript:;>>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>> 
>>>>>>>>>>>>> Apache Phoenix has one code template
which
>> contributors
>>>> use.
>>>>>> Do
>>>>>>>> you
>>>>>>>>>>>> think
>>>>>>>>>>>>> onc can use the same for Flink or may
be with some
>> more
>>>>>>>>> modifications?
>>>>>>>>>>>>> 
>>>>>>>>>>>>> 
>>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>> 
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>>> 
>> https://github.com/apache/phoenix/blob/master/dev/PhoenixCodeTemplate.xml
>>>>>>>>>>>>> 
>>>>>>>>>>>>> On Sat, Apr 9, 2016 at 11:00 AM, Stephan
Ewen <
>>>>>> sewen@apache.org
>>>>>>>>> <javascript:;>>
>>>>>>>>>> wrote:
>>>>>>>>>>>>> 
>>>>>>>>>>>>>> Actually, It would be amazing to
create a code style
>>>>> profile
>>>>>>> for
>>>>>>>>>>>>> download,
>>>>>>>>>>>>>> so that all contributors would use
that.
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> Same thing actually for IntelliJ
inspections: A set
>> of
>>>>>>>> inspections
>>>>>>>>>> we
>>>>>>>>>>>>> want
>>>>>>>>>>>>>> to have active and where we strive
for zero
>> warnings.
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> On Sat, Apr 9, 2016 at 10:00 AM,
Robert Metzger <
>>>>>>>>>> rmetzger@apache.org <javascript:;>>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> Hi Dawid,
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> we don't have an automated formatter
for intelliJ.
>>>>>> However,
>>>>>>>> you
>>>>>>>>>> can
>>>>>>>>>>>> use
>>>>>>>>>>>>>> the
>>>>>>>>>>>>>>> "Checkstyle" plugin of IntelliJ
to mark checkstyle
>>>>>>> violations
>>>>>>>> in
>>>>>>>>>> the
>>>>>>>>>>>>> IDE.
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> On Fri, Apr 8, 2016 at 12:30
PM, Dawid Wysakowicz
>> <
>>>>>>>>>>>>>>> wysakowicz.dawid@gmail.com <javascript:;>>
wrote:
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> Hi all,
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> I am currently working on
some issues and been
>>>>> wondering
>>>>>>> if
>>>>>>>>> you
>>>>>>>>>>>> have
>>>>>>>>>>>>>>>> settings for Intellij code
style that would
>> follow
>>>>> your
>>>>>>>> coding
>>>>>>>>>>>>>> guidelines
>>>>>>>>>>>>>>>> available (I tried to look
on wikis but could
>> not
>>>> find
>>>>>>> it).
>>>>>>>> If
>>>>>>>>>> not
>>>>>>>>>>>>>> could
>>>>>>>>>>>>>>>> someone share its own? I
would be grateful.
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> Regards
>>>>>>>>>>>>>>>> Dawid Wysakowicz
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> 
>>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> --
>>>>>>>>>> BR,
>>>>>>>>>> Stefano Baghino
>>>>>>>>>> 
>>>>>>>>>> Software Engineer @ Radicalbit
>>>>>>>>>> 
>>>>>>>>> 
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>>> 
>> 


Mime
View raw message