flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aljoscha Krettek (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FLINK-3803) Checkpoint Stats Tracker Reads from Wrong Configuration
Date Fri, 22 Apr 2016 11:46:12 GMT
Aljoscha Krettek created FLINK-3803:
---------------------------------------

             Summary: Checkpoint Stats Tracker Reads from Wrong Configuration
                 Key: FLINK-3803
                 URL: https://issues.apache.org/jira/browse/FLINK-3803
             Project: Flink
          Issue Type: Bug
          Components: Streaming
    Affects Versions: 1.0.0
            Reporter: Aljoscha Krettek


In {{ExecutionGraph.java}} when configuring the checkpoint stats tracker the config values
are read from the {{jobConfiguration}}:

{code}
boolean isStatsDisabled = jobConfiguration.getBoolean(
        ConfigConstants.JOB_MANAGER_WEB_CHECKPOINTS_DISABLE,
        ConfigConstants.DEFAULT_JOB_MANAGER_WEB_CHECKPOINTS_DISABLE);

if (isStatsDisabled) {
    checkpointStatsTracker = new DisabledCheckpointStatsTracker();
}
else {
    int historySize = jobConfiguration.getInteger(
            ConfigConstants.JOB_MANAGER_WEB_CHECKPOINTS_HISTORY_SIZE,
            ConfigConstants.DEFAULT_JOB_MANAGER_WEB_CHECKPOINTS_HISTORY_SIZE);

    checkpointStatsTracker = new SimpleCheckpointStatsTracker(historySize, tasksToWaitFor);
}
{code}

The settings are only available in the Flink Configuration, however. Right now, the {{ExecutionGraph}}
has no access to the Flink Configuration.

I see three solutions:
 - pass the Flink Configuration to the {{ExecutionGraph}}
 - pass just the two required settings to the {{ExecutionGraph}}
 - Introduce a new {{ExecutionGraphSettings}} that contains settings only for the {{ExecutionGraph}}
in order to clean up things a bit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message