Return-Path: X-Original-To: apmail-flink-dev-archive@www.apache.org Delivered-To: apmail-flink-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E50EA19DA2 for ; Tue, 22 Mar 2016 11:04:25 +0000 (UTC) Received: (qmail 3304 invoked by uid 500); 22 Mar 2016 11:04:25 -0000 Delivered-To: apmail-flink-dev-archive@flink.apache.org Received: (qmail 3241 invoked by uid 500); 22 Mar 2016 11:04:25 -0000 Mailing-List: contact dev-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list dev@flink.apache.org Received: (qmail 3213 invoked by uid 99); 22 Mar 2016 11:04:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Mar 2016 11:04:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7F2B02C14DC for ; Tue, 22 Mar 2016 11:04:25 +0000 (UTC) Date: Tue, 22 Mar 2016 11:04:25 +0000 (UTC) From: "Aljoscha Krettek (JIRA)" To: dev@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (FLINK-3646) Use Processing-Time Clock in Window Assigners/Triggers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Aljoscha Krettek created FLINK-3646: --------------------------------------- Summary: Use Processing-Time Clock in Window Assigners/Triggers Key: FLINK-3646 URL: https://issues.apache.org/jira/browse/FLINK-3646 Project: Flink Issue Type: Sub-task Components: Streaming Affects Versions: 1.0.0 Reporter: Aljoscha Krettek This is part of the effort to improve Window Triggers in Flink. We should replace all usage of {{System.currentTimeMillis()}} by a provided clock implementation. This way we can use a deterministic testing clock to verify the behavior of processing-time windowing components in unit tests. This requires the following changes: - Change {{StreamTask}} to have a {{Clock}} (name is WIP). By default this clock will use {{System.currentTimeMillis()}}. The clock must also provide an interface to register processing-time triggers, this is currently handled directly by {{StreamTask}} but must now also be handled by an external Clock - Change API of {{WindowAssigner}} to take a context object that allows it to query the current processing time. This can be an abstract class {{AssignerContext}} with a single method {{long currentProcessingTime()}} - Add a method {{long currentProcessingTime()}} in {{TriggerContext}}, change {{TriggerContext}} to use the clock methods provided by {{StreamTask}} and forwarded by {{WindowOperator}} - Change processing-time triggers to use the new methods - Change {{WindowOperator}} to support these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)