flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Ewen <se...@apache.org>
Subject Re: [VOTE] Release Apache Flink 1.0.0 (RC5)
Date Fri, 04 Mar 2016 10:51:21 GMT
Are the docs actually wrong?

In the docs, it says to run the "tools/change-scala-version.sh 2.11" script
first (which implicitly adds the "-Dscala-2.11" flag.

I thought this problem arose because neither the flag was specified, nor
the script run.

On Fri, Mar 4, 2016 at 11:43 AM, Ufuk Celebi <uce@apache.org> wrote:

> @Stefano: Yes, would be great to have a fix in the docs and pointers
> on how to improve the docs for this.
>
> On Fri, Mar 4, 2016 at 11:41 AM, Stefano Baghino
> <stefano.baghino@radicalbit.io> wrote:
> > Build successful, thank you.
> >
> > On Fri, Mar 4, 2016 at 11:24 AM, Stefano Baghino <
> > stefano.baghino@radicalbit.io> wrote:
> >
> >> I'll try it immediately, thanks for the quick feedback and sorry for the
> >> intrusion. Should I add this to the docs? The flag seem to be
> >> -Dscala.version=2.11.x on them:
> >>
> https://ci.apache.org/projects/flink/flink-docs-master/setup/building.html#scala-versions
> >>
> >> On Fri, Mar 4, 2016 at 11:20 AM, Stephan Ewen <sewen@apache.org> wrote:
> >>
> >>> Sorry, the flag is "-Dscala-2.11"
> >>>
> >>> On Fri, Mar 4, 2016 at 11:19 AM, Stephan Ewen <sewen@apache.org>
> wrote:
> >>>
> >>> > Hi!
> >>> >
> >>> > To compile with Scala 2.11, please use the "-Dscala.version=2.11"
> flag.
> >>> > Otherwise the 2.11 specific build profiles will not get properly
> >>> activated.
> >>> >
> >>> > Can you try that again?
> >>> >
> >>> > Thanks,
> >>> > Stephan
> >>> >
> >>> >
> >>> > On Fri, Mar 4, 2016 at 11:17 AM, Stefano Baghino <
> >>> > stefano.baghino@radicalbit.io> wrote:
> >>> >
> >>> >> I won't cast a vote as I'm not entirely sure this is just a local
> >>> problem
> >>> >> (and from the document the Scala 2.11 build has been checked),
> however
> >>> >> I've
> >>> >> checked out the `release-1.0-rc5` branch and ran `mvn clean install
> >>> >> -DskipTests -Dscala.version=2.11.7`, with a failure on
> `flink-runtime`:
> >>> >>
> >>> >> [ERROR]
> >>> >>
> >>> >>
> >>>
> /Users/Stefano/Projects/flink/flink-runtime/src/test/scala/org/apache/flink/runtime/jobmanager/JobManagerITCase.scala:703:
> >>> >> error: can't expand macros compiled by previous versions of Scala
> >>> >> [ERROR]               assert(cachedGraph2.isArchived)
> >>> >> [ERROR]                                   ^
> >>> >> [ERROR] one error found
> >>> >>
> >>> >> Is the 2.11 build still compiling successfully according to your
> latest
> >>> >> tests?
> >>> >> I've tried running a clean and re-running without skipping the
tests
> >>> but
> >>> >> the issue persists.
> >>> >>
> >>> >> On Fri, Mar 4, 2016 at 10:38 AM, Stephan Ewen <sewen@apache.org>
> >>> wrote:
> >>> >>
> >>> >> > +1
> >>> >> >
> >>> >> > Checked LICENSE and NOTICE files
> >>> >> > Built against Hadoop 2.6, Scala 2.10, all tests are good
> >>> >> > Run local pseudo cluster with examples
> >>> >> > Log files look good, no exceptions
> >>> >> > Tested File State Backend
> >>> >> > Ran Storm Compatibility Examples
> >>> >> >    -> minor issue, one example fails (no release blocker
in my
> >>> opinion)
> >>> >> >
> >>> >> >
> >>> >> > On Thu, Mar 3, 2016 at 5:41 PM, Till Rohrmann <
> trohrmann@apache.org>
> >>> >> > wrote:
> >>> >> >
> >>> >> > > +1
> >>> >> > >
> >>> >> > > Checked that the sources don't contain binaries
> >>> >> > > Tested cluster execution with flink/run and web client
job
> >>> submission
> >>> >> > > Run all examples via FliRTT
> >>> >> > > Tested Kafka 0.9
> >>> >> > > Verified that quickstarts work with Eclipse and IntelliJ
> >>> >> > > Run example with RemoteEnvironment
> >>> >> > > Verified SBT quickstarts
> >>> >> > >
> >>> >> > > On Thu, Mar 3, 2016 at 3:43 PM, Aljoscha Krettek <
> >>> aljoscha@apache.org
> >>> >> >
> >>> >> > > wrote:
> >>> >> > >
> >>> >> > > > +1
> >>> >> > > >
> >>> >> > > > I think we have a winner. :D
> >>> >> > > >
> >>> >> > > > The “boring” tests from the checklist should
still hold for
> this
> >>> RC
> >>> >> > and I
> >>> >> > > > now ran a custom windowing job with state on RocksDB
on Hadoop
> >>> 2.7
> >>> >> with
> >>> >> > > > Scala 2.11. I used the Yarn HA mode and shot down
both
> >>> JobManagers
> >>> >> and
> >>> >> > > > TaskManagers and the job restarted successfully.
I also
> verified
> >>> >> that
> >>> >> > > > savepoints work in this setup.
> >>> >> > > >
> >>> >> > > > > On 03 Mar 2016, at 14:08, Robert Metzger <
> rmetzger@apache.org>
> >>> >> > wrote:
> >>> >> > > > >
> >>> >> > > > > Apparently I was not careful enough when writing
the email.
> >>> >> > > > > The release branch is "release-1.0.0-rc5" and
its the fifth
> RC.
> >>> >> > > > >
> >>> >> > > > > On Thu, Mar 3, 2016 at 2:01 PM, Robert Metzger
<
> >>> >> rmetzger@apache.org>
> >>> >> > > > wrote:
> >>> >> > > > >
> >>> >> > > > >> Dear Flink community,
> >>> >> > > > >>
> >>> >> > > > >> Please vote on releasing the following
candidate as Apache
> >>> Flink
> >>> >> > > version
> >>> >> > > > >> 1.0.0.
> >>> >> > > > >>
> >>> >> > > > >> This is the fourth RC.
> >>> >> > > > >> Here is a document to report on the testing
and release
> >>> >> > verification:
> >>> >> > > > >>
> >>> >> > > >
> >>> >> > >
> >>> >> >
> >>> >>
> >>>
> https://docs.google.com/document/d/1hoQ5k4WQteNj2OoPwpQPD4ZVHrCwM1pTlUVww8ld7oY/edit#heading=h.2v6zy51pgj33
> >>> >> > > > >>
> >>> >> > > > >>
> >>> >> > > > >> The commit to be voted on (*
> >>> >> > > > http://git-wip-us.apache.org/repos/asf/flink/commit/94cd554a
> >>> >> > > > >> <
> http://git-wip-us.apache.org/repos/asf/flink/commit/94cd554a
> >>> >*)
> >>> >> > > > >> 94cd554aee39413588bd30890dc7aed886b1c91d
> >>> >> > > > >>
> >>> >> > > > >> Branch:
> >>> >> > > > >> release-1.0.0-rc4 (see
> >>> >> > > > >>
> >>> >> > > >
> >>> >> > >
> >>> >> >
> >>> >>
> >>>
> https://git1-us-west.apache.org/repos/asf/flink/repo?p=flink.git;a=shortlog;h=refs/heads/release-1.0.0-rc5
> >>> >> > > > >> )
> >>> >> > > > >>
> >>> >> > > > >> The release artifacts to be voted on can
be found at:
> >>> >> > > > >> *http://home.apache.org/~rmetzger/flink-1.0.0-rc5/
> >>> >> > > > >> <http://home.apache.org/~rmetzger/flink-1.0.0-rc5/>*
> >>> >> > > > >>
> >>> >> > > > >> The release artifacts are signed with the
key with
> fingerprint
> >>> >> > > D9839159:
> >>> >> > > > >> http://www.apache.org/dist/flink/KEYS
> >>> >> > > > >>
> >>> >> > > > >> The staging repository for this release
can be found at:
> >>> >> > > > >> *
> >>> >> > >
> >>> >>
> https://repository.apache.org/content/repositories/orgapacheflink-1069
> >>> >> > > > >> <
> >>> >> > >
> >>> >>
> https://repository.apache.org/content/repositories/orgapacheflink-1069
> >>> >> > > > >*
> >>> >> > > > >>
> >>> >> > > > >>
> -------------------------------------------------------------
> >>> >> > > > >>
> >>> >> > > > >> The vote is open until Friday and passes
if a majority of
> at
> >>> >> least
> >>> >> > > three
> >>> >> > > > >> +1 PMC votes are cast.
> >>> >> > > > >>
> >>> >> > > > >> The vote ends on Friday, March 4, 19:00
CET.
> >>> >> > > > >>
> >>> >> > > > >> [ ] +1 Release this package as Apache Flink
1.0.0
> >>> >> > > > >> [ ] -1 Do not release this package because
...
> >>> >> > > > >>
> >>> >> > > > >>
> >>> >> > > > >> ----------------------------------------------------------
> >>> >> > > > >>
> >>> >> > > > >> Changes since RC4:
> >>> >> > > > >>
> >>> >> > > > >> commit a79521fba60407ff5a800ec78fcfeee750d826d6
> >>> >> > > > >> Author: Robert Metzger <rmetzger@apache.org>
> >>> >> > > > >> Date:   Thu Mar 3 09:32:40 2016 +0100
> >>> >> > > > >>
> >>> >> > > > >>    [hotfix] Make 'force-shading' deployable
> >>> >> > > > >>
> >>> >> > > > >> commit 3adc51487aaae97469fc05e511be85d0a75a21d3
> >>> >> > > > >> Author: Maximilian Michels <mxm@apache.org>
> >>> >> > > > >> Date:   Wed Mar 2 17:52:05 2016 +0100
> >>> >> > > > >>
> >>> >> > > > >>    [maven] add module to force execution
of Shade plugin
> >>> >> > > > >>
> >>> >> > > > >>    This ensures that all properties of
the root pom are
> >>> properly
> >>> >> > > > >>    resolved by running the Shade plugin.
Thus, our root pom
> >>> does
> >>> >> not
> >>> >> > > > have
> >>> >> > > > >>    to depend on a Scala version just because
it holds the
> >>> Scala
> >>> >> > > version
> >>> >> > > > >>    properties.
> >>> >> > > > >>
> >>> >> > > > >> commit b862fd0b3657d8b9026a54782bad5a1fb71c19f4
> >>> >> > > > >> Author: Márton Balassi <mbalassi@apache.org>
> >>> >> > > > >> Date:   Sun Feb 21 23:01:00 2016 +0100
> >>> >> > > > >>
> >>> >> > > > >>    [FLINK-3422][streaming] Update tests
reliant on hashing
> >>> >> > > > >>
> >>> >> > > > >> commit a049d80e8aef7f0d23fbc06d263fb3e7a0f2f05f
> >>> >> > > > >> Author: Gabor Horvath <xazax.hun@gmail.com>
> >>> >> > > > >> Date:   Sun Feb 21 14:54:44 2016 +0100
> >>> >> > > > >>
> >>> >> > > > >>    [FLINK-3422][streaming][api-breaking]
Scramble
> >>> HashPartitioner
> >>> >> > > > hashes.
> >>> >> > > > >>
> >>> >> > > > >>
> >>> >> > > > >>
> >>> >> > > >
> >>> >> > > >
> >>> >> > >
> >>> >> >
> >>> >>
> >>> >>
> >>> >>
> >>> >> --
> >>> >> BR,
> >>> >> Stefano Baghino
> >>> >>
> >>> >> Software Engineer @ Radicalbit
> >>> >>
> >>> >
> >>> >
> >>>
> >>
> >>
> >>
> >> --
> >> BR,
> >> Stefano Baghino
> >>
> >> Software Engineer @ Radicalbit
> >>
> >
> >
> >
> > --
> > BR,
> > Stefano Baghino
> >
> > Software Engineer @ Radicalbit
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message