flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Metzger <rmetz...@apache.org>
Subject Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc4)
Date Mon, 02 Nov 2015 21:56:23 GMT
+1 for the approach without the full LICENSE/NOTICE for binary releases. As
long as the source releases are correct there should be no problem

On Mon, Nov 2, 2015 at 7:11 PM, Aljoscha Krettek <aljoscha@apache.org>
wrote:

> Sorry for the back-and-forth guys. I updated my PR to completely remove
> the LICENSE/NOTICE files that where specific to the binary release. Now we
> just copy over the LICENSE/NOTICE files from the source release. This is
> also how Hadoop does it, by the way.
>
> > On 02 Nov 2015, at 17:51, Aljoscha Krettek <aljoscha@apache.org> wrote:
> >
> > Hi,
> > I also discovered that basically we would need to provide custom
> LICENSE/NOTICE files for our released binaries for different hadoop/scala/…
> versions
> > because they come with different dependencies (that we also include due
> to shading).
> >
> > For example, this is the dependency tree for flink-shaded-hadoop2 (Flink
> 0.9.0, Hadoop 2.4.0):
> > [INFO] +- org.apache.hadoop:hadoop-common:jar:2.4.0:compile
> > [INFO] |  +- org.apache.hadoop:hadoop-annotations:jar:2.4.0:compile
> > [INFO] |  +- com.google.guava:guava:jar:11.0.2:compile
> > [INFO] |  +- commons-cli:commons-cli:jar:1.2:compile
> > [INFO] |  +- org.apache.commons:commons-math3:jar:3.1.1:compile
> > [INFO] |  +- xmlenc:xmlenc:jar:0.52:compile
> > [INFO] |  +- commons-httpclient:commons-httpclient:jar:3.1:compile
> > [INFO] |  +- commons-codec:commons-codec:jar:1.4:compile
> > [INFO] |  +- commons-io:commons-io:jar:2.4:compile
> > [INFO] |  +- commons-net:commons-net:jar:3.1:compile
> > [INFO] |  +- commons-collections:commons-collections:jar:3.2.1:compile
> > [INFO] |  +- com.sun.jersey:jersey-core:jar:1.9:compile
> > [INFO] |  +- com.sun.jersey:jersey-json:jar:1.9:compile
> > [INFO] |  |  +- org.codehaus.jettison:jettison:jar:1.1:compile
> > [INFO] |  |  +- com.sun.xml.bind:jaxb-impl:jar:2.2.3-1:compile
> > [INFO] |  |  |  \- javax.xml.bind:jaxb-api:jar:2.2.2:compile
> > [INFO] |  |  |     +- javax.xml.stream:stax-api:jar:1.0-2:compile
> > [INFO] |  |  |     \- javax.activation:activation:jar:1.1:compile
> > [INFO] |  |  +- org.codehaus.jackson:jackson-jaxrs:jar:1.8.3:compile
> > [INFO] |  |  \- org.codehaus.jackson:jackson-xc:jar:1.8.3:compile
> > [INFO] |  +- com.sun.jersey:jersey-server:jar:1.9:compile
> > [INFO] |  +- commons-el:commons-el:jar:1.0:runtime
> > [INFO] |  +- commons-logging:commons-logging:jar:1.1.3:compile
> > [INFO] |  +- net.java.dev.jets3t:jets3t:jar:0.9.0:compile
> > [INFO] |  |  +- org.apache.httpcomponents:httpclient:jar:4.1.2:compile
> > [INFO] |  |  +- org.apache.httpcomponents:httpcore:jar:4.1.2:compile
> > [INFO] |  |  \- com.jamesmurty.utils:java-xmlbuilder:jar:0.4:compile
> > [INFO] |  +- commons-lang:commons-lang:jar:2.6:compile
> > [INFO] |  +- commons-configuration:commons-configuration:jar:1.6:compile
> > [INFO] |  |  +- commons-digester:commons-digester:jar:1.8:compile
> > [INFO] |  |  |  \- commons-beanutils:commons-beanutils:jar:1.7.0:compile
> > [INFO] |  |  \-
> commons-beanutils:commons-beanutils-core:jar:1.8.0:compile
> > [INFO] |  +- org.codehaus.jackson:jackson-core-asl:jar:1.8.8:compile
> > [INFO] |  +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.8:compile
> > [INFO] |  +- org.apache.avro:avro:jar:1.7.6:compile
> > [INFO] |  |  +- com.thoughtworks.paranamer:paranamer:jar:2.3:compile
> > [INFO] |  |  \- org.xerial.snappy:snappy-java:jar:1.0.5:compile
> > [INFO] |  +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
> > [INFO] |  +- org.apache.hadoop:hadoop-auth:jar:2.4.0:compile
> > [INFO] |  +- com.jcraft:jsch:jar:0.1.42:compile
> > [INFO] |  +- com.google.code.findbugs:jsr305:jar:1.3.9:compile
> > [INFO] |  +- org.apache.zookeeper:zookeeper:jar:3.4.5:compile
> > [INFO] |  \- org.apache.commons:commons-compress:jar:1.4.1:compile
> > [INFO] |     \- org.tukaani:xz:jar:1.0:compile
> > [INFO] +- org.apache.hadoop:hadoop-hdfs:jar:2.4.0:compile
> > [INFO] |  +- commons-daemon:commons-daemon:jar:1.0.13:compile
> > [INFO] |  \- javax.servlet.jsp:jsp-api:jar:2.1:compile
> > [INFO] +-
> org.apache.hadoop:hadoop-mapreduce-client-core:jar:2.4.0:compile
> > [INFO] +- org.apache.commons:commons-lang3:jar:3.3.2:compile
> > [INFO] +- org.slf4j:slf4j-api:jar:1.7.7:compile
> > [INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.7:compile
> > [INFO] +- log4j:log4j:jar:1.2.17:compile
> > [INFO] +- junit:junit:jar:4.11:test
> > [INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
> > [INFO] +- org.mockito:mockito-all:jar:1.9.5:test
> > [INFO] +- org.powermock:powermock-module-junit4:jar:1.5.5:test
> > [INFO] |  \- org.powermock:powermock-module-junit4-common:jar:1.5.5:test
> > [INFO] |     +- org.powermock:powermock-core:jar:1.5.5:test
> > [INFO] |     |  \- org.javassist:javassist:jar:3.18.1-GA:test
> > [INFO] |     \- org.powermock:powermock-reflect:jar:1.5.5:test
> > [INFO] |        \- org.objenesis:objenesis:jar:2.1:test
> > [INFO] +- org.powermock:powermock-api-mockito:jar:1.5.5:test
> > [INFO] |  \- org.powermock:powermock-api-support:jar:1.5.5:test
> > [INFO] \- org.hamcrest:hamcrest-all:jar:1.3:test
> >
> > And this is the dependency tree for flink-shaded-hadoop2 (Flink 0.9.0,
> Hadoop 2.5.0):
> > [INFO] +- org.apache.hadoop:hadoop-common:jar:2.5.0:compile
> > [INFO] |  +- org.apache.hadoop:hadoop-annotations:jar:2.5.0:compile
> > [INFO] |  +- com.google.guava:guava:jar:11.0.2:compile
> > [INFO] |  +- commons-cli:commons-cli:jar:1.2:compile
> > [INFO] |  +- org.apache.commons:commons-math3:jar:3.1.1:compile
> > [INFO] |  +- xmlenc:xmlenc:jar:0.52:compile
> > [INFO] |  +- commons-httpclient:commons-httpclient:jar:3.1:compile
> > [INFO] |  +- commons-codec:commons-codec:jar:1.4:compile
> > [INFO] |  +- commons-io:commons-io:jar:2.4:compile
> > [INFO] |  +- commons-net:commons-net:jar:3.1:compile
> > [INFO] |  +- commons-collections:commons-collections:jar:3.2.1:compile
> > [INFO] |  +- com.sun.jersey:jersey-core:jar:1.9:compile
> > [INFO] |  +- com.sun.jersey:jersey-json:jar:1.9:compile
> > [INFO] |  |  +- org.codehaus.jettison:jettison:jar:1.1:compile
> > [INFO] |  |  +- com.sun.xml.bind:jaxb-impl:jar:2.2.3-1:compile
> > [INFO] |  |  |  \- javax.xml.bind:jaxb-api:jar:2.2.2:compile
> > [INFO] |  |  |     +- javax.xml.stream:stax-api:jar:1.0-2:compile
> > [INFO] |  |  |     \- javax.activation:activation:jar:1.1:compile
> > [INFO] |  |  +- org.codehaus.jackson:jackson-jaxrs:jar:1.8.3:compile
> > [INFO] |  |  \- org.codehaus.jackson:jackson-xc:jar:1.8.3:compile
> > [INFO] |  +- com.sun.jersey:jersey-server:jar:1.9:compile
> > [INFO] |  +- commons-el:commons-el:jar:1.0:runtime
> > [INFO] |  +- commons-logging:commons-logging:jar:1.1.3:compile
> > [INFO] |  +- net.java.dev.jets3t:jets3t:jar:0.9.0:compile
> > [INFO] |  |  +- org.apache.httpcomponents:httpclient:jar:4.1.2:compile
> > [INFO] |  |  +- org.apache.httpcomponents:httpcore:jar:4.1.2:compile
> > [INFO] |  |  \- com.jamesmurty.utils:java-xmlbuilder:jar:0.4:compile
> > [INFO] |  +- commons-lang:commons-lang:jar:2.6:compile
> > [INFO] |  +- commons-configuration:commons-configuration:jar:1.6:compile
> > [INFO] |  |  +- commons-digester:commons-digester:jar:1.8:compile
> > [INFO] |  |  |  \- commons-beanutils:commons-beanutils:jar:1.7.0:compile
> > [INFO] |  |  \-
> commons-beanutils:commons-beanutils-core:jar:1.8.0:compile
> > [INFO] |  +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
> > [INFO] |  +- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile
> > [INFO] |  +- org.apache.avro:avro:jar:1.7.6:compile
> > [INFO] |  |  +- com.thoughtworks.paranamer:paranamer:jar:2.3:compile
> > [INFO] |  |  \- org.xerial.snappy:snappy-java:jar:1.0.5:compile
> > [INFO] |  +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
> > [INFO] |  +- org.apache.hadoop:hadoop-auth:jar:2.5.0:compile
> > [INFO] |  |  \-
> org.apache.directory.server:apacheds-kerberos-codec:jar:2.0.0-M15:compile
> > [INFO] |  |     +-
> org.apache.directory.server:apacheds-i18n:jar:2.0.0-M15:compile
> > [INFO] |  |     +-
> org.apache.directory.api:api-asn1-api:jar:1.0.0-M20:compile
> > [INFO] |  |     \-
> org.apache.directory.api:api-util:jar:1.0.0-M20:compile
> > [INFO] |  +- com.jcraft:jsch:jar:0.1.42:compile
> > [INFO] |  +- com.google.code.findbugs:jsr305:jar:1.3.9:compile
> > [INFO] |  +- org.apache.zookeeper:zookeeper:jar:3.4.6:compile
> > [INFO] |  \- org.apache.commons:commons-compress:jar:1.4.1:compile
> > [INFO] |     \- org.tukaani:xz:jar:1.0:compile
> > [INFO] +- org.apache.hadoop:hadoop-hdfs:jar:2.5.0:compile
> > [INFO] |  +- commons-daemon:commons-daemon:jar:1.0.13:compile
> > [INFO] |  +- javax.servlet.jsp:jsp-api:jar:2.1:compile
> > [INFO] |  \- io.netty:netty:jar:3.6.2.Final:compile
> > [INFO] +-
> org.apache.hadoop:hadoop-mapreduce-client-core:jar:2.5.0:compile
> > [INFO] +- org.apache.commons:commons-lang3:jar:3.3.2:compile
> > [INFO] +- org.slf4j:slf4j-api:jar:1.7.7:compile
> > [INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.7:compile
> > [INFO] +- log4j:log4j:jar:1.2.17:compile
> > [INFO] +- junit:junit:jar:4.11:test
> > [INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
> > [INFO] +- org.mockito:mockito-all:jar:1.9.5:test
> > [INFO] +- org.powermock:powermock-module-junit4:jar:1.5.5:test
> > [INFO] |  \- org.powermock:powermock-module-junit4-common:jar:1.5.5:test
> > [INFO] |     +- org.powermock:powermock-core:jar:1.5.5:test
> > [INFO] |     |  \- org.javassist:javassist:jar:3.18.1-GA:test
> > [INFO] |     \- org.powermock:powermock-reflect:jar:1.5.5:test
> > [INFO] |        \- org.objenesis:objenesis:jar:2.1:test
> > [INFO] +- org.powermock:powermock-api-mockito:jar:1.5.5:test
> > [INFO] |  \- org.powermock:powermock-api-support:jar:1.5.5:test
> > [INFO] \- org.hamcrest:hamcrest-all:jar:1.3:test
> >
> > If you sort them and diff it you get this:
> > --- 0.9-deps-hadoop24-sorted  2015-11-02 17:43:19.000000000 +0100
> > +++ 0.9-deps-hadoop25-sorted  2015-11-02 17:43:28.000000000 +0100
> > @@ -1,16 +1,15 @@
> > [INFO] +- junit:junit:jar:4.11:test
> > [INFO] +- log4j:log4j:jar:1.2.17:compile
> > [INFO] +- org.apache.commons:commons-lang3:jar:3.3.2:compile
> > -[INFO] +- org.apache.hadoop:hadoop-common:jar:2.4.0:compile
> > -[INFO] +- org.apache.hadoop:hadoop-hdfs:jar:2.4.0:compile
> > -[INFO] +-
> org.apache.hadoop:hadoop-mapreduce-client-core:jar:2.4.0:compile
> > +[INFO] +- org.apache.hadoop:hadoop-common:jar:2.5.0:compile
> > +[INFO] +- org.apache.hadoop:hadoop-hdfs:jar:2.5.0:compile
> > +[INFO] +-
> org.apache.hadoop:hadoop-mapreduce-client-core:jar:2.5.0:compile
> > [INFO] +- org.mockito:mockito-all:jar:1.9.5:test
> > [INFO] +- org.powermock:powermock-api-mockito:jar:1.5.5:test
> > [INFO] +- org.powermock:powermock-module-junit4:jar:1.5.5:test
> > [INFO] +- org.slf4j:slf4j-api:jar:1.7.7:compile
> > [INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.7:compile
> > [INFO] \- org.hamcrest:hamcrest-all:jar:1.3:test
> > -[INFO] org.apache.flink:flink-shaded-hadoop2:jar:0.9.0
> > [INFO] |        \- org.objenesis:objenesis:jar:2.1:test
> > [INFO] |     +- org.powermock:powermock-core:jar:1.5.5:test
> > [INFO] |     \- org.powermock:powermock-reflect:jar:1.5.5:test
> > @@ -34,20 +33,24 @@
> > [INFO] |  +- commons-lang:commons-lang:jar:2.6:compile
> > [INFO] |  +- commons-logging:commons-logging:jar:1.1.3:compile
> > [INFO] |  +- commons-net:commons-net:jar:3.1:compile
> > +[INFO] |  +- javax.servlet.jsp:jsp-api:jar:2.1:compile
> > [INFO] |  +- net.java.dev.jets3t:jets3t:jar:0.9.0:compile
> > [INFO] |  +- org.apache.avro:avro:jar:1.7.6:compile
> > [INFO] |  +- org.apache.commons:commons-math3:jar:3.1.1:compile
> > -[INFO] |  +- org.apache.hadoop:hadoop-annotations:jar:2.4.0:compile
> > -[INFO] |  +- org.apache.hadoop:hadoop-auth:jar:2.4.0:compile
> > -[INFO] |  +- org.apache.zookeeper:zookeeper:jar:3.4.5:compile
> > -[INFO] |  +- org.codehaus.jackson:jackson-core-asl:jar:1.8.8:compile
> > -[INFO] |  +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.8:compile
> > +[INFO] |  +- org.apache.hadoop:hadoop-annotations:jar:2.5.0:compile
> > +[INFO] |  +- org.apache.hadoop:hadoop-auth:jar:2.5.0:compile
> > +[INFO] |  +- org.apache.zookeeper:zookeeper:jar:3.4.6:compile
> > +[INFO] |  +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
> > +[INFO] |  +- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile
> > [INFO] |  +- xmlenc:xmlenc:jar:0.52:compile
> > -[INFO] |  \- javax.servlet.jsp:jsp-api:jar:2.1:compile
> > +[INFO] |  \- io.netty:netty:jar:3.6.2.Final:compile
> > [INFO] |  \- org.apache.commons:commons-compress:jar:1.4.1:compile
> > [INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
> > [INFO] |  \- org.powermock:powermock-api-support:jar:1.5.5:test
> > [INFO] |  \- org.powermock:powermock-module-junit4-common:jar:1.5.5:test
> > +[INFO] |  |     +-
> org.apache.directory.api:api-asn1-api:jar:1.0.0-M20:compile
> > +[INFO] |  |     +-
> org.apache.directory.server:apacheds-i18n:jar:2.0.0-M15:compile
> > +[INFO] |  |     \-
> org.apache.directory.api:api-util:jar:1.0.0-M20:compile
> > [INFO] |  |  +- com.sun.xml.bind:jaxb-impl:jar:2.2.3-1:compile
> > [INFO] |  |  +- com.thoughtworks.paranamer:paranamer:jar:2.3:compile
> > [INFO] |  |  +- commons-digester:commons-digester:jar:1.8:compile
> > @@ -57,6 +60,7 @@
> > [INFO] |  |  +- org.codehaus.jettison:jettison:jar:1.1:compile
> > [INFO] |  |  \- com.jamesmurty.utils:java-xmlbuilder:jar:0.4:compile
> > [INFO] |  |  \-
> commons-beanutils:commons-beanutils-core:jar:1.8.0:compile
> > +[INFO] |  |  \-
> org.apache.directory.server:apacheds-kerberos-codec:jar:2.0.0-M15:compile
> > [INFO] |  |  \- org.codehaus.jackson:jackson-xc:jar:1.8.3:compile
> > [INFO] |  |  \- org.xerial.snappy:snappy-java:jar:1.0.5:compile
> > [INFO] |  |  |     +- javax.xml.stream:stax-api:jar:1.0-2:compile
> >
> > In other words, quite different.
> >
> > Cheers,
> > Aljoscha
> >
> >> On 02 Nov 2015, at 16:27, Ufuk Celebi <uce@apache.org> wrote:
> >>
> >> I think your comment was misleading. It sounded like you added the
> actual dependency to the POM and not just to the LICENSE file.
> >>
> >>> On 02 Nov 2015, at 16:26, Aljoscha Krettek <aljoscha@apache.org>
> wrote:
> >>>
> >>> This is the PR: https://github.com/apache/flink/pull/1316 if anyone
> is interested or knows something about how we have to declare licenses.
> >>>> On 02 Nov 2015, at 16:10, Aljoscha Krettek <aljoscha@apache.org>
> wrote:
> >>>>
> >>>> flink-storm has a dependency on storm-core. Therefore I though it
> should be added to the LICENSE file (not the one in root but the one we
> ship with the binary distribution).
> >>>>> On 02 Nov 2015, at 16:00, Matthias J. Sax <mjsax@apache.org>
wrote:
> >>>>>
> >>>>> You added Storm dependency? Why? Which version? How does it affect
> >>>>> storm-compatibility?
> >>>>>
> >>>>> We decided to not include Storm as dependency to Flink when I started
> >>>>> with it. Thus, fat-jars must include Storm classes if storm-compat
> is use.
> >>>>>
> >>>>> On 11/02/2015 03:07 PM, Maximilian Michels wrote:
> >>>>>> Alright. Good finds. I'll cancel the release candidate and will
> create
> >>>>>> a new one once the fixes are in.
> >>>>>>
> >>>>>> On Mon, Nov 2, 2015 at 3:02 PM, Aljoscha Krettek <
> aljoscha@apache.org> wrote:
> >>>>>>> I also have an open PR that adds some new dependencies,
most
> notably Nifi, Storm, betty-router and Elasticsearch, and removes AWS.
> >>>>>>>> On 02 Nov 2015, at 14:39, Aljoscha Krettek <aljoscha@apache.org>
> wrote:
> >>>>>>>>
> >>>>>>>> -1
> >>>>>>>> We include openjdk JMH and this is GPL v2 license. This
could be
> a problem.
> >>>>>>>>> On 02 Nov 2015, at 14:27, Fabian Hueske <fhueske@gmail.com>
> wrote:
> >>>>>>>>>
> >>>>>>>>> -1
> >>>>>>>>> A user reported a bug in the Scala DataSet API:
FLINK-2953
> >>>>>>>>>
> >>>>>>>>> Should be easy to solve. I will provide a fix soon.
> >>>>>>>>>
> >>>>>>>>> 2015-10-30 15:51 GMT+01:00 Maximilian Michels <mxm@apache.org>:
> >>>>>>>>>
> >>>>>>>>>> We can continue testing now:
> >>>>>>>>>>
> >>>>>>>>>>
> https://docs.google.com/document/d/1keGYj2zj_AOOKH1bC43Xc4MDz0eLhTErIoxevuRtcus/edit
> >>>>>>>>>>
> >>>>>>>>>> On Fri, Oct 30, 2015 at 3:49 PM, Maximilian
Michels <
> mxm@apache.org>
> >>>>>>>>>> wrote:
> >>>>>>>>>>
> >>>>>>>>>>> Please vote on releasing the following candidate
as Apache
> Flink version
> >>>>>>>>>>> 0.10.0:
> >>>>>>>>>>>
> >>>>>>>>>>> The commit to be voted on:
> >>>>>>>>>>> 6044b7f0366deec547022e4bc40c49e1b1c83f28
> >>>>>>>>>>>
> >>>>>>>>>>> Branch:
> >>>>>>>>>>> release-0.10.0-rc4 (see
> >>>>>>>>>>> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git)
> >>>>>>>>>>>
> >>>>>>>>>>> The release artifacts to be voted on can
be found at:
> >>>>>>>>>>> http://people.apache.org/~mxm/flink-0.10.0-rc4/
> >>>>>>>>>>>
> >>>>>>>>>>> The release artifacts are signed with the
key with fingerprint
> C2909CBF:
> >>>>>>>>>>> http://www.apache.org/dist/flink/KEYS
> >>>>>>>>>>>
> >>>>>>>>>>> The staging repository for this release
can be found at:
> >>>>>>>>>>>
> https://repository.apache.org/content/repositories/orgapacheflink-1051
> >>>>>>>>>>>
> >>>>>>>>>>> -------------------------------------------------------------
> >>>>>>>>>>>
> >>>>>>>>>>> The vote is open for the next 72 hours and
passes if a
> majority of at
> >>>>>>>>>>> least three +1 PMC votes are cast.
> >>>>>>>>>>>
> >>>>>>>>>>> The vote ends on Monday November 2, 2015.
> >>>>>>>>>>>
> >>>>>>>>>>> [ ] +1 Release this package as Apache Flink
0.10.0
> >>>>>>>>>>> [ ] -1 Do not release this package because
...
> >>>>>>>>>>>
> >>>>>>>>>>> ===================================
> >>>>>>>>>>>
> >>>>>>>>>>> The following commits have been added on
top of
> release-0.10.0-rc3:
> >>>>>>>>>>>
> >>>>>>>>>>> 698fbc3 [release][scripts] shade away curator
correctly with
> different
> >>>>>>>>>>> Scala versions
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>
> >>>>
> >>>
> >>
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message