Return-Path: X-Original-To: apmail-flink-dev-archive@www.apache.org Delivered-To: apmail-flink-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4917E173E5 for ; Thu, 24 Sep 2015 14:22:46 +0000 (UTC) Received: (qmail 20011 invoked by uid 500); 24 Sep 2015 14:22:46 -0000 Delivered-To: apmail-flink-dev-archive@flink.apache.org Received: (qmail 19955 invoked by uid 500); 24 Sep 2015 14:22:46 -0000 Mailing-List: contact dev-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list dev@flink.apache.org Received: (qmail 19938 invoked by uid 99); 24 Sep 2015 14:22:46 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Sep 2015 14:22:46 +0000 Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 7BA691A003F for ; Thu, 24 Sep 2015 14:22:45 +0000 (UTC) Received: by wiclk2 with SMTP id lk2so30680846wic.0 for ; Thu, 24 Sep 2015 07:22:44 -0700 (PDT) X-Received: by 10.180.106.66 with SMTP id gs2mr10765002wib.14.1443104564078; Thu, 24 Sep 2015 07:22:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.11.129 with HTTP; Thu, 24 Sep 2015 07:22:24 -0700 (PDT) In-Reply-To: <3721E580-C8AF-405D-BC83-CE004FDB1E45@apache.org> References: <55783256.5070609@tu-ilmenau.de> <44F50DFB-1409-4E57-9AD5-79C317573B53@icloud.com> <5578391A.3090509@tu-ilmenau.de> <81BB99AE-355C-4C7E-BD8F-075F4F8CF8A8@icloud.com> <55783FF8.9090904@tu-ilmenau.de> <1B59007C-E416-424C-A8B0-A8B0954E8045@icloud.com> <4DE21837-ED92-4F2B-A0DE-17BDD99917BF@icloud.com> <4CC84481-0D16-40F5-9729-E281FA218C49@apache.org> <7DF9253E-82ED-4AF2-BF27-B0091D8C0247@apache.org> <84049F7C-8B65-4E03-8739-7893D583FFC3@apache.org> <3721E580-C8AF-405D-BC83-CE004FDB1E45@apache.org> From: Robert Metzger Date: Thu, 24 Sep 2015 16:22:24 +0200 Message-ID: Subject: Re: Flink 0.9 built with Scala 2.11 To: "dev@flink.apache.org" Content-Type: multipart/alternative; boundary=f46d04451a0dea71cd05207ef625 --f46d04451a0dea71cd05207ef625 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Just a note that FLINK-2200 has been resolved. All flink artifacts are now two times in the maven snapshot repository: one without a suffix (scala 2.10) and one with a suffix (_2.11 for scala 2.11). There is also a nightly _2.11 binary release for Flink: http://stratosphere-bin.s3.amazonaws.com/flink-0.10-SNAPSHOT-bin-hadoop2_2.= 11.tgz There is no hadoop1_2.11 artifact. I'm for now assuming that somebody who's using the latest scala is not using a legacy Hadoop version ;) I would appreciate some testing from users who requested this feature to make sure everything is working as expected for the next major release. We need to make sure that no 2.10 dependency is coming in anywhere and that Flink with Scala 2.11 is working properly. On Tue, Jul 7, 2015 at 1:58 PM, Chiwan Park wrote: > I cannot find talking about pure/non-pure java distinction in the > documentation. > > I defined the rules about artifact id to apply modules by only Scala > version not > pure/non-pure java. The modules without suffix `_2.11` means that they ar= e > linked with Scala 2.10 binary. > > If I misunderstood your sentence or missed the talking in documentation, > please > notify me. > > Regards, > Chiwan Park > > > On Jul 6, 2015, at 8:07 PM, Alexander Alexandrov < > alexander.s.alexandrov@gmail.com> wrote: > > > >> Because we are using Scala in our runtime, all modules are Scala > > dependent module. > > > > If all modules will need the suffix after your PR is merged, why would > you > > talk about pure/non-pure distinction in the documentation? This adds > > complexity and may cause confusion which at the moment can be spared. I= f > in > > the future a "pure Java module" (without) is introduced, the > documentation > > can be updated accordingly. > > > > My two cents regarding the "optional suffix policy" are that thinks > should > > be kept simple. If Scala has penetrated 100% percent of the current > > modules, new modules should be "proactive" and anticipate that this wil= l > > likely happen to them in the future, even if they start as "pure Java".= I > > prefer a strict policy that makes everything clear for the user (even i= f > it > > is a bit inefficient in terms of packaging and release management) as > > opposed to a naming convention based on implementation-details. > > > > Regards, > > A. > > > > > > 2015-07-05 13:16 GMT+02:00 Chiwan Park : > > > >> @Stephan: Okay, I=E2=80=99ll find the mentionings in other document. I= think > that > >> we > >> can postpone updating downloads page in flink-web until releasing 0.10= . > >> > >> @Alexandar Thank you for comments. I=E2=80=99ll apply your suggestions= . > >> > >> In your example, *flink-pure-java* is not pure java module. If there i= s > >> any need > >> of linkage with Scala dependent module in some module, the module is > also > >> Scala dependent module. Because we are using Scala in our runtime, all > >> modules are Scala dependent module. > >> > >> So in your example, *flink-some-scala-A*, *flink-some-scala-B*, and > >> *flink-pure-java* should have a suffix `_2.11` if the user want to run > in > >> Flink > >> with Scala 2.11. (In Scala 2.10, we don=E2=80=99t need it.) > >> > >> I agree that it makes too many modules. But it is clear in user > >> perspective. The > >> users just decide which Scala version to use their cluster and add a > >> suffix to > >> all dependency if the version is 2.11. > >> > >> Regards, > >> Chiwan Park > >> > >>> On Jul 3, 2015, at 9:26 PM, Stephan Ewen wrote: > >>> > >>> @Chiwan: > >>> > >>> There are a few mentionings of the Scala version in the docs as well. > For > >>> example in "docs/index.md" and on the website under "downloads". > >>> > >>> We should make sure we explain on these pages that there are download= s > >> for > >>> various Scala versions. > >>> > >>> Cheers, > >>> Stephan > >>> > >>> > >>> On Fri, Jul 3, 2015 at 2:01 PM, Alexander Alexandrov < > >>> alexander.s.alexandrov@gmail.com> wrote: > >>> > >>>> Great, I just posted some comments / improvement suggestions. > >>>> > >>>> I have to say I'm still not 100% convinced by the strategy not to ad= d > a > >>>> suffix to all modules. Here is a small example that illustrates my > >>>> concerns. > >>>> > >>>> Consider the following chained dependency situation. We have pure Ja= va > >>>> artifact *flink-pure-java* which depends on a Scala artifact > >>>> *flink-some-scala-A*, which in turn depends on *flink-some-scala-B*. > >>>> > >>>> Let's say the user has directly included *flink-pure-java* and > >>>> *flink-some-scala-B* in the his project and wants to build for Scala > >> 2.11. > >>>> We end up with a situation like this > >>>> > >>>> - flink-pure-java > >>>> `- flink-some-scala-A > >>>> `- flink-some-scala-B > >>>> - flink-some-scala-B_2.11 > >>>> > >>>> We end up having both versions of *flink-some-scala-B* in our projec= t. > >>>> > >>>> > >>>> > >>>> 2015-07-03 12:24 GMT+02:00 Chiwan Park : > >>>> > >>>>> Hi All, > >>>>> I created a PR for this issue. [1] Please check and comment about t= he > >> PR. > >>>>> > >>>>> Regards, > >>>>> Chiwan Park > >>>>> > >>>>> [1] https://github.com/apache/flink/pull/885 > >>>>> > >>>>>> On Jul 2, 2015, at 5:59 PM, Chiwan Park > >> wrote: > >>>>>> > >>>>>> @Alexander I=E2=80=99m happy to hear that you want to help me. If = you help > me, > >>>> I > >>>>> really appreciate. :) > >>>>>> > >>>>>> Regards, > >>>>>> Chiwan Park > >>>>>> > >>>>>> > >>>>>>> On Jul 2, 2015, at 2:57 PM, Alexander Alexandrov < > >>>>> alexander.s.alexandrov@gmail.com> wrote: > >>>>>>> > >>>>>>> @Chiwan: let me know if you need hands-on support. I'll be more > then > >>>>> happy to help (as my downstream project is using Scala 2.11). > >>>>>>> > >>>>>>> 2015-07-01 17:43 GMT+02:00 Chiwan Park : > >>>>>>> Okay, I will apply this suggestion. > >>>>>>> > >>>>>>> Regards, > >>>>>>> Chiwan Park > >>>>>>> > >>>>>>>> On Jul 1, 2015, at 5:41 PM, Ufuk Celebi wrote: > >>>>>>>> > >>>>>>>> > >>>>>>>> On 01 Jul 2015, at 10:34, Stephan Ewen wrote: > >>>>>>>> > >>>>>>>>> +1, like that approach > >>>>>>>> > >>>>>>>> +1 > >>>>>>>> > >>>>>>>> I like that this is not breaking for non-Scala users :-) > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>>> > >>>>> > >>>>> > >>>>> > >>>>> > >>>> > >> > >> > >> > >> > >> > > > > > --f46d04451a0dea71cd05207ef625--