flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Ewen <se...@apache.org>
Subject Re: Code style guideline for Scala
Date Sun, 16 Aug 2015 14:06:30 GMT
Hi!

I very much support that. A bit stricter rules in the style checkers lead
to more uniform and better readable code. We can have stricter rules both
in Java and Scala.

Note that the hardest part of adding the style checks is actually adjusting
all the existing code that violates the style.

The best approach would probably be for someone to make a suggestion what
should go into the checkstyle, and then reiterate on it.

Greetings,
Stephan




On Sun, Aug 16, 2015 at 12:14 PM, Chiwan Park <chiwanpark@apache.org> wrote:

> Hi All,
>
> I’m reviewing some pull requests written in Scala. While reviewing, I
> think that scala style checker is too loose and documentation about code
> style guideline in wiki [1] is poor. The code style for Scala doesn’t seems
> unified as that for Java.
>
> I suggest upgrading version of scalastyle-maven-plugin to 0.7.0, adding
> some rules such as NoWhitespaceBeforeLeftBracketChecker,
> EnsureSingleSpaceAfterTokenChecker, IndentationChecker, and
> MagicNumberChecker and updating the documentation in wiki.
>
> I hope to discuss the code style for Scala. How think you about this?
>
> Regards,
> Chiwan Park
>
> [1]
> https://cwiki.apache.org/confluence/display/FLINK/Coding+Guidelines+for+Scala

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message