flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Ewen <se...@apache.org>
Subject Re: [jira](FLINK-2493) Simplify names of example program JARs
Date Fri, 14 Aug 2015 09:06:26 GMT
Concerning mixed projects: Should be okay even for Eclipse users, because
no Scala code is referenced from Java code (that is the tricky part).
Even for someone without a Scala IDE plugin, they would simply not
interpret the "src/main/scala" directory, which should make this appear
like a pure Java project to them.

Concerning name overlap: How about we put them in different packages:
"org.apache.flink.examples.java" and "org.apache.flink.examples.scala". I
am also fine with dropping the subpackages like "graph" or so. Not like we
have so many examples that we need subpackages ;-)

On Fri, Aug 14, 2015 at 11:01 AM, Till Rohrmann <till.rohrmann@gmail.com>
wrote:

> In case of merging we would have to add a `scala` tag to some of the
> examples because some of the examples exist in both packages. The drawback
> of merging both examples modules is that we'll have another mixed
> Java/Scala project. This might be bothering for the eclipse folks, but we
> already have that. It might make sense to keep the examples separated if
> they use different dependencies. Other than that, I think both of your
> proposals are fine.
>
> Slightly off-topic: What we could also do is to move the shared components
> (e.g. the testing data) to a distinct module (flink-examples/example-data).
> But since the generated scala job jars only contain the java data classes
> this won't change much at all.
>
> On Fri, Aug 14, 2015 at 10:52 AM, Stephan Ewen <sewen@apache.org> wrote:
>
> > +1 for proposal (2)
> >
> > On Fri, Aug 14, 2015 at 10:28 AM, Fabian Hueske <fhueske@gmail.com>
> wrote:
> >
> > > Hi Liang Chen,
> > >
> > > thanks for starting this discussion.
> > >
> > > I have no strong preference for one of your proposals. Both are fine
> with
> > > me.
> > >
> > > What would proposal 2 mean if we add examples for other API languages,
> > for
> > > example if the Python API moves out of staging?
> > > I guess it shouldn't be a problem, because all examples are
> > self-contained.
> > > Any other thoughts on this?
> > >
> > > Best, Fabian
> > >
> > > 2015-08-14 0:32 GMT+02:00 Liang Chen <chenliang613@huawei.com>:
> > >
> > > > Summary:Simplify names of example program JARs
> > > > Key:FLINK-2493, URL:https://issues.apache.org/jira/browse/FLINK-2493
> > > > Issue Type: Improvement
> > > > Components:Examples
> > > >
> > > > Propose to simplify the name to "examples/ConnectedComponents.jar"
> > rather
> > > > than
> examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar
> > > >
> > > > Two proposals, wants to discuss:
> > > > Proposal 1:
> > > > Change the pom of "flink-java-examples", use executed-example name as
> > > > "finalName" to replace "default
> > > finalName(artifactId+version)+classifier".
> > > > keep two projects(flink-java-examples,flink-scala-examples) under
> > > > "flink-examples".
> > > >
> > > > Proposal 2:Combine "flink-java-examples" and "flink-scala-examples"
> > > project
> > > > to one project with "flink-examples", because the Scala example
> mostly
> > > need
> > > > import  Java example' util/*data*.class, work together.
> > > > this would be no any impaction for examples.
> > > >
> > > > please give your ideas, any input would be very appreciated.
> > > >
> > > >
> > > >
> > > > --
> > > > View this message in context:
> > > >
> > >
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/jira-FLINK-2493-Simplify-names-of-example-program-JARs-tp7495.html
> > > > Sent from the Apache Flink Mailing List archive. mailing list archive
> > at
> > > > Nabble.com.
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message