Mailing-List: contact dev-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAGco--YVsozK1Es8A_40pUDxr+yjwpHorqMkmN_NVDwy1EYKgw@mail.gmail.com>
References: <55A779A7.7000904@informatik.hu-berlin.de>
 <2EB74DE6-10D1-48DA-B8D1-D20EA6AB1D62@apache.org>
 <CAGco--YVsozK1Es8A_40pUDxr+yjwpHorqMkmN_NVDwy1EYKgw@mail.gmail.com>
From: Maximilian Michels <mxm@apache.org>
Date: Thu, 16 Jul 2015 14:24:16 +0200
Message-ID: 
 <CAGco--Y-uvQe+wQdFSvtXeifT3toi7fQioCE9ZMXAeJf6Kf_2A@mail.gmail.com>
Subject: Re: Failing Test
To: dev@flink.apache.org
Content-Type: multipart/alternative; boundary=089e0112d15e8c0ddc051afd2765

--089e0112d15e8c0ddc051afd2765
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Matthias,

I've pushed a fix to the master. The problem should be solved. Please tell
me if your Travis reports an error again. My Travis never complained :)

Cheers,
Max

On Thu, Jul 16, 2015 at 12:00 PM, Maximilian Michels <mxm@apache.org> wrote=
:

> Hi Matthias,
>
> This is indeed a timing issue when checking for the results in this test.
> The new accumulator implementation now continuously reports from the
> running tasks to the job manager. This was merged yesterday.
>
> The assertion that fails there is a bit strict. Actually, I've already
> integrated a retry mechanism that fails only if the assertions don't hold
> for a configured number of times.
>
> I'll commit a fix to the master. Thanks for reporting!
>
> Cheers,
> Max
>
> On Thu, Jul 16, 2015 at 11:33 AM, Ufuk Celebi <uce@apache.org> wrote:
>
>> Hey,
>>
>> this has been merged yesterday. I guess it's a timing issue when
>> verifying the results. Can you file an issue for this?
>>
>> =E2=80=93 Ufuk
>>
>> On 16 Jul 2015, at 11:30, Matthias J. Sax <mjsax@informatik.hu-berlin.de=
>
>> wrote:
>>
>> > Hi,
>> >
>> > I hit another failing test (that is new to me):
>> >
>> >> Results :
>> >> Failed tests:
>> >>
>> AccumulatorLiveITCase.testProgram:106->access$1100:68->checkFlinkAccumul=
ators:189
>> null
>> >
>> >
>> >> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.694
>> sec <<< FAILURE! - in
>> org.apache.flink.test.accumulators.AccumulatorLiveITCase
>> >> testProgram(org.apache.flink.test.accumulators.AccumulatorLiveITCase)
>> Time elapsed: 8.021 sec <<< FAILURE!
>> >> java.lang.AssertionError: null
>> >> at org.junit.Assert.fail(Assert.java:86)
>> >> at org.junit.Assert.assertTrue(Assert.java:41)
>> >> at org.junit.Assert.assertTrue(Assert.java:52)
>> >> at
>> org.apache.flink.test.accumulators.AccumulatorLiveITCase.checkFlinkAccum=
ulators(AccumulatorLiveITCase.java:189)
>> >> at
>> org.apache.flink.test.accumulators.AccumulatorLiveITCase.access$1100(Acc=
umulatorLiveITCase.java:68)
>> >
>> > Please see: https://travis-ci.org/mjsax/flink/jobs/71179608
>> >
>> > Does anyone know anything about it?
>> >
>> > BTW: Even if this test is in flink-tests, the problem seems not to be
>> > related to https://issues.apache.org/jira/browse/FLINK-2032 because
>> > accumulators are tested. There are not result files involved (as fas a=
s
>> > I can tell).
>> >
>> >
>> >
>> > -Matthias
>> >
>>
>>
>

--089e0112d15e8c0ddc051afd2765--