flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gyula Fóra <gyula.f...@gmail.com>
Subject Re: Revert 78fd2146dd until we have consensus for FLINK-2419?
Date Tue, 28 Jul 2015 18:19:30 GMT
Hey,

I am sorry that you feel bad about this, I only did not add a test
case for FLINK-2419
because I am adding a test in my upcoming PR which verified the behaviour.

As for FLINK-2423, it is actually very bad that issue is still there. You
introduced this in your PR https://github.com/apache/flink/pull/895 which I
commented but no one fixed it before merging. As developing a test takes
quite much time here as it is tricky, I wanted to push the fix, which was
in fact trivial.

Regards,
Gyula

Robert Metzger <rmetzger@apache.org> ezt írta (időpont: 2015. júl. 28., K,
20:01):

> Hi,
>
> I'm a bit unhappy how we were handling
> https://issues.apache.org/jira/browse/FLINK-2419 today.
>
> I raised a concern in the JIRA because the commit for the fix didn't
> contain any tests. Our coding guidelines [1] imply that every feature
> should have tests. Apparently there were not enough tests for the two bugs
> fixed with commit 78fd2146dd.
>
> Also, Gyula's answer sounds like he is not willing to add tests right now.
>
> I can not remember if we ever reverted a commit in the Flink community, but
> in my understanding, this is how ASF projects are doing lazy consensus for
> commits-without-PR.
> So if there is a disagreement in the associated JIRA, we revert the fix
> until there is an agreement.
>
> In this case, I did not immediately revert the commit, because I would like
> to see whether others in the community agree with me.
>
>
> What do you think how we should handle cases like this one in the future?
>
> I think its very important for committers and PMC members to be a good
> example when it comes to following our own rules. Otherwise, how can we ask
> our contributors to adhere to these rules?
>
>
> My suggestion to resolve this situation is the following:
> - Revert commit 78fd2146dd
> - open pull requests for FLINK-2419 and FLINK-2423 (with tests of course),
> review and merge them.
>
>
>
> Best,
> Robert
>
> [1] http://flink.apache.org/coding-guidelines.html
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message