flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MaGuoWei <maguo...@outlook.com>
Subject RE: question about SlidingPreReducer.java
Date Thu, 30 Jul 2015 10:20:56 GMT
I find function addToBufferIfEligible always resets currentReduced to null so that branch can
never be reached.  (SlidingCountPreReducer.java)
 

> Date: Thu, 30 Jul 2015 12:06:54 +0200
> Subject: Re: question about SlidingPreReducer.java
> From: till.rohrmann@gmail.com
> To: dev@flink.apache.org
> 
> But if the updateCurrent method is called at least twice with a value
> different from null, then the else branch should be executed if I’m not
> mistaken. In the first call currentReduced will be sets to something other
> than null (if branch) and in the second call the reducer will be called
> with the next element (else branch).
> ​
> 
> On Thu, Jul 30, 2015 at 11:54 AM, MaGuoWei <maguowei@outlook.com> wrote:
> 
> > hi till
> > I mean the branch of the if statement is never execute.
> > thanks
> >
> > 发自我的 iPhone
> >
> > > 在 2015年7月30日,下午5:51,Till Rohrmann <till.rohrmann@gmail.com>
写道:
> > >
> > > Hi MaGuoWei,
> > >
> > > do you mean that the branch of the if statement (line 130) is never
> > > executed? Or are you looking for an example which uses the
> > SlidingPreReducer
> > > ?
> > >
> > > Cheers,
> > > Till
> > > ​
> > >
> > >> On Thu, Jul 30, 2015 at 11:33 AM, MaGuoWei <maguowei@outlook.com>
> > wrote:
> > >>
> > >> hi guysThere is a function updateCurrent() in this
> > >> class(SlidingPreReducer).I think there is no chance to run the following
> > >> code in this function:currentReduced =
> > >> reducer.reduce(serializer.copy(currentReduced), element);Can any one
> > give
> > >> me a example that can run this code.  (I have already see all the test
> > >> case)thanks a lot
> > >>
> >
 		 	   		  
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message